components/nacl.gyp - Issue 212793010: Revert of Set the default ASan options for executables built with ASan on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl.gyp

Issue 212793010: Revert of Set the default ASan options for executables built with ASan on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl.gyp

diff --git a/components/nacl.gyp b/components/nacl.gyp

index 1942e220061b8d926c8c45bb12b65cb5715cb8ca..9cf8d9276a12a9f05d5e3ffe598a30719c53f964 100644

--- a/components/nacl.gyp

+++ b/components/nacl.gyp

@@ -187,12 +187,6 @@

'../sandbox/sandbox.gyp:sandbox',

'../ppapi/ppapi_internal.gyp:ppapi_proxy',

- 'ldflags!': [

- # Do not pick the default ASan options from

- # base/debug/sanitizer_options.cc to avoid th conflict with

- # those in nacl/nacl_helper_linux.cc.

- '-Wl,-u_sanitizer_options_link_helper',

- ],

'defines': [

'<@(nacl_defines)',

# Allow .cc files to know if they're being compiled as part

« no previous file with comments | « chrome/app/chrome_exe_main_gtk.cc ('k') | no next file » | no next file with comments »