Fix attributes types on AnalyserNode as specification of web audio.

Fix attributes types on AnalyserNode as specification of web audio.

According to specification, minDecibels, maxDicibels and smoothingTimeConstant are defined to double.
Specification mismatched, internal member valuables already are defined to double as well.
Do not need to cast from float to double.

http://www.w3.org/TR/webaudio/#AnalyserNode

BUG=356636
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170469

[KhNo, 2014-03-26 12:27:55]

Please review patch. Thank you. :)

[Raymond Toy, 2014-03-26 17:00:08]

On 2014/03/26 12:27:55, KhNo wrote:
> Please review patch. Thank you. :)

lgtm.

And I see you can submit try jobs now.

[KhNo, 2014-03-26 17:16:00]

On 2014/03/26 17:00:08, Raymond Toy wrote:
> On 2014/03/26 12:27:55, KhNo wrote:
> > Please review patch. Thank you. :)
> 
> lgtm.
> 
> And I see you can submit try jobs now.

Thank you so much for it. :)

[KhNo, 2014-03-26 17:17:10]

The CQ bit was checked by keonho07.kim@samsung.com

[commit-bot: I haz the power, 2014-03-26 17:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/212793002/1

[commit-bot: I haz the power, 2014-03-26 17:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 17:17:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[KhNo, 2014-03-26 17:26:31]

On 2014/03/26 17:17:27, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Do you think I need more step in my side for ownership issue?

[Raymond Toy, 2014-03-26 17:49:39]

On 2014/03/26 17:26:31, KhNo wrote:
> On 2014/03/26 17:17:27, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a lowly provisional committer, _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> Do you think I need more step in my side for ownership issue?

I think I'm missing something on my end. I'm trying to get this straightened
out. You can ask another reviewer if you don't want to wait.

Oh, it would be nice to add a simple test that you get the desired values.  I
think currently if you set one of the attributes to 1/3, you won't get back 1/3
now.  This CL will make that true.

[KhNo, 2014-03-27 00:53:30]

On 2014/03/26 17:49:39, Raymond Toy wrote:
> On 2014/03/26 17:26:31, KhNo wrote:
> > On 2014/03/26 17:17:27, I haz the power (commit-bot) wrote:
> > > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > > Even if an LGTM may have been provided, it was from a non-committer or
> > > a lowly provisional committer, _not_ a full super star committer.
> > > See http://www.chromium.org/getting-involved/become-a-committer
> > > Note that this has nothing to do with OWNERS files.
> > 
> > Do you think I need more step in my side for ownership issue?
> 
> I think I'm missing something on my end. I'm trying to get this straightened
> out. You can ask another reviewer if you don't want to wait.
> 
> Oh, it would be nice to add a simple test that you get the desired values.  I
> think currently if you set one of the attributes to 1/3, you won't get back
1/3
> now.  This CL will make that true.

I think this patch is not critical and no dependancy with my next patches.
I would like to wait and help your straightenning to check proper ownership.

[KhNo, 2014-03-27 13:22:00]

> Oh, it would be nice to add a simple test that you get the desired values.  I
> think currently if you set one of the attributes to 1/3, you won't get back
1/3
> now.  This CL will make that true.

Raymond. I have added basic layout test and dom exception test.
There are spec mismatches. Those are also fixed together.

minDecibels
The default value is -100. If the value of this attribute is set to a value more
than or equal to maxDecibels, an INDEX_SIZE_ERR exception MUST be thrown.

maxDecibels
The default value is -30. If the value of this attribute is set to a value less
than or equal to minDecibels, an INDEX_SIZE_ERR exception MUST be thrown.

[Raymond Toy, 2014-03-27 17:33:08]

Thanks for the tests; these look good, but I have a few comments.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
File LayoutTests/webaudio/dom-exceptions.html (right):

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
LayoutTests/webaudio/dom-exceptions.html:77: shouldThrow("node.maxDecibels =
-100");
How are these two tests different from the two above?

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
File LayoutTests/webaudio/realtimeanalyser-basic.html (right):

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:31: testFailed("AnalyserNode
should have one input.");
Make this and the following failed tests a little more informative.  For this
one,

testFailed("AnalyserNode should have one input, not " + analyser.numberOfInputs
+ ".")

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:53: analyser.minDecibelss =
1/3;
Fix typo: minDecibelss -> minDecibels. This test doesn't actually test what you
want as is. And then you'll get an error because the new minDecibels is greater
than maxDecibels.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:59: analyser.maxDecibelss =
1/3;
Fix typo: maxDecibelss -> maxDecibels

[Raymond Toy, 2014-03-27 17:34:52]

A question about the trybots.  Did you manually chose the set of trybots to run?
I normally use git cl try which normally selects a much larger set of trybots. I
think that's better coverage.

[KhNo, 2014-03-28 02:25:22]

Could you check the patch set #4 ?

I got different result from original code.
FAIL minDecibels value should be set to -50.333333333333336, not
-50.33333206176758.
FAIL maxDecibels value should be set to -40.333333333333336, not
-40.33333206176758.

I think it seems to be check properly.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
File LayoutTests/webaudio/dom-exceptions.html (right):

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
LayoutTests/webaudio/dom-exceptions.html:77: shouldThrow("node.maxDecibels =
-100");
On 2014/03/27 17:33:09, Raymond Toy wrote:
> How are these two tests different from the two above?

-30 and -100 are default values.
There were bugs when those are set exactly same value.
Previously There are just existed about bigger or less values.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
File LayoutTests/webaudio/realtimeanalyser-basic.html (right):

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:31: testFailed("AnalyserNode
should have one input.");
On 2014/03/27 17:33:09, Raymond Toy wrote:
> Make this and the following failed tests a little more informative.  For this
> one,
> 
> testFailed("AnalyserNode should have one input, not " +
analyser.numberOfInputs
> + ".")

Oh, that is much better. Thanks.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:53: analyser.minDecibelss =
1/3;
On 2014/03/27 17:33:09, Raymond Toy wrote:
> Fix typo: minDecibelss -> minDecibels. This test doesn't actually test what
you
> want as is. And then you'll get an error because the new minDecibels is
greater
> than maxDecibels.

Done. and I will correctly change it I missed.

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:59: analyser.maxDecibelss =
1/3;
On 2014/03/27 17:33:09, Raymond Toy wrote:
> Fix typo: maxDecibelss -> maxDecibels

Done.

[KhNo, 2014-03-28 02:28:09]

On 2014/03/27 17:34:52, Raymond Toy wrote:
> A question about the trybots.  Did you manually chose the set of trybots to
run?
> I normally use git cl try which normally selects a much larger set of trybots.
I
> think that's better coverage.

Yes. I has done. I thought developer shouldn't give a big load to try build
server.
Thanks for information. I will using general way "git cl try" for better
coverage once.
And then select manually if there is a failure.

[Raymond Toy, 2014-03-28 16:10:06]

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
File LayoutTests/webaudio/dom-exceptions.html (right):

https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
LayoutTests/webaudio/dom-exceptions.html:77: shouldThrow("node.maxDecibels =
-100");
On 2014/03/28 02:25:23, KhNo wrote:
> On 2014/03/27 17:33:09, Raymond Toy wrote:
> > How are these two tests different from the two above?
> 
> -30 and -100 are default values.
> There were bugs when those are set exactly same value.
> Previously There are just existed about bigger or less values.

Ah, so we set minDecibels = -30, which is the same as maxDecibels, so we should
signal an error, as required.  Nice catch.

https://codereview.chromium.org/212793002/diff/80001/LayoutTests/webaudio/rea...
File LayoutTests/webaudio/realtimeanalyser-basic.html (right):

https://codereview.chromium.org/212793002/diff/80001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:54: if (analyser.minDecibels
=== -50.0 - (1/3))
Change lines 53-57 to

var expectedValue = -50 - (1/3);
analyser.minDecibels = expectedValue;
if (analyser.minDecibels === expectedValue)
  testPassed("minDecibels value is set to " + expectedValue + ".")
else
  testFailed("minDecibels value should be set to " + expectedValue + ", not " +
analyser.minDecibels + ".");

https://codereview.chromium.org/212793002/diff/80001/LayoutTests/webaudio/rea...
LayoutTests/webaudio/realtimeanalyser-basic.html:59: analyser.maxDecibels =
-40.0 - (1/3);
Same as above.

[Raymond Toy, 2014-03-28 16:11:15]

On 2014/03/28 02:25:22, KhNo wrote:
> Could you check the patch set #4 ?
> 
> I got different result from original code.
> FAIL minDecibels value should be set to -50.333333333333336, not
> -50.33333206176758.
> FAIL maxDecibels value should be set to -40.333333333333336, not
> -40.33333206176758.

This is what you get when you run the test in chrome stable/beta/canary?  That
looks right then.

> 
> I think it seems to be check properly.
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
> File LayoutTests/webaudio/dom-exceptions.html (right):
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/dom...
> LayoutTests/webaudio/dom-exceptions.html:77: shouldThrow("node.maxDecibels =
> -100");
> On 2014/03/27 17:33:09, Raymond Toy wrote:
> > How are these two tests different from the two above?
> 
> -30 and -100 are default values.
> There were bugs when those are set exactly same value.
> Previously There are just existed about bigger or less values.
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
> File LayoutTests/webaudio/realtimeanalyser-basic.html (right):
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
> LayoutTests/webaudio/realtimeanalyser-basic.html:31: testFailed("AnalyserNode
> should have one input.");
> On 2014/03/27 17:33:09, Raymond Toy wrote:
> > Make this and the following failed tests a little more informative.  For
this
> > one,
> > 
> > testFailed("AnalyserNode should have one input, not " +
> analyser.numberOfInputs
> > + ".")
> 
> Oh, that is much better. Thanks.
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
> LayoutTests/webaudio/realtimeanalyser-basic.html:53: analyser.minDecibelss =
> 1/3;
> On 2014/03/27 17:33:09, Raymond Toy wrote:
> > Fix typo: minDecibelss -> minDecibels. This test doesn't actually test what
> you
> > want as is. And then you'll get an error because the new minDecibels is
> greater
> > than maxDecibels.
> 
> Done. and I will correctly change it I missed.
> 
>
https://codereview.chromium.org/212793002/diff/40001/LayoutTests/webaudio/rea...
> LayoutTests/webaudio/realtimeanalyser-basic.html:59: analyser.maxDecibelss =
> 1/3;
> On 2014/03/27 17:33:09, Raymond Toy wrote:
> > Fix typo: maxDecibelss -> maxDecibels
> 
> Done.

[KhNo, 2014-03-29 00:35:51]

> This is what you get when you run the test in chrome stable/beta/canary?  That
> looks right then.
> 


Yes, I tested as you said.

[KhNo, 2014-03-29 00:45:42]

PTAL :) once again.

[Raymond Toy, 2014-03-31 16:47:37]

On 2014/03/29 00:45:42, KhNo wrote:
> PTAL :) once again.

lgtm with minor comment.  Please fix the issue before committing.

[Raymond Toy, 2014-03-31 16:47:54]

https://codereview.chromium.org/212793002/diff/140001/LayoutTests/webaudio/re...
File LayoutTests/webaudio/realtimeanalyser-basic.html (right):

https://codereview.chromium.org/212793002/diff/140001/LayoutTests/webaudio/re...
LayoutTests/webaudio/realtimeanalyser-basic.html:5: <script
src="resources/audio-testing.js"></script>
Add

<script src="resoruces/compatibility.js"></script>

so we can still run this test on older browsers.

[KhNo, 2014-03-31 17:13:18]

Thank you. I have added compatibility.js

https://codereview.chromium.org/212793002/diff/140001/LayoutTests/webaudio/re...
File LayoutTests/webaudio/realtimeanalyser-basic.html (right):

https://codereview.chromium.org/212793002/diff/140001/LayoutTests/webaudio/re...
LayoutTests/webaudio/realtimeanalyser-basic.html:5: <script
src="resources/audio-testing.js"></script>
On 2014/03/31 16:47:55, Raymond Toy wrote:
> Add
> 
> <script src="resoruces/compatibility.js"></script>
> 
> so we can still run this test on older browsers.

Done.

[KhNo, 2014-03-31 17:14:43]

The CQ bit was checked by keonho07.kim@samsung.com

[commit-bot: I haz the power, 2014-03-31 17:14:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/212793002/160001

[commit-bot: I haz the power, 2014-03-31 18:24:53]

Change committed as 170469