Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: Source/modules/webaudio/RealtimeAnalyser.h

Issue 212793002: Fix attributes types on AnalyserNode as specification of web audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add compatibility.js Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/webaudio/AnalyserNode.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 27 matching lines...) Expand all
38 class RealtimeAnalyser FINAL { 38 class RealtimeAnalyser FINAL {
39 WTF_MAKE_NONCOPYABLE(RealtimeAnalyser); 39 WTF_MAKE_NONCOPYABLE(RealtimeAnalyser);
40 public: 40 public:
41 RealtimeAnalyser(); 41 RealtimeAnalyser();
42 42
43 size_t fftSize() const { return m_fftSize; } 43 size_t fftSize() const { return m_fftSize; }
44 bool setFftSize(size_t); 44 bool setFftSize(size_t);
45 45
46 unsigned frequencyBinCount() const { return m_fftSize / 2; } 46 unsigned frequencyBinCount() const { return m_fftSize / 2; }
47 47
48 void setMinDecibels(float k) { m_minDecibels = k; } 48 void setMinDecibels(double k) { m_minDecibels = k; }
49 float minDecibels() const { return static_cast<float>(m_minDecibels); } 49 double minDecibels() const { return m_minDecibels; }
50 50
51 void setMaxDecibels(float k) { m_maxDecibels = k; } 51 void setMaxDecibels(double k) { m_maxDecibels = k; }
52 float maxDecibels() const { return static_cast<float>(m_maxDecibels); } 52 double maxDecibels() const { return m_maxDecibels; }
53 53
54 void setSmoothingTimeConstant(float k) { m_smoothingTimeConstant = k; } 54 void setSmoothingTimeConstant(double k) { m_smoothingTimeConstant = k; }
55 float smoothingTimeConstant() const { return static_cast<float>(m_smoothingT imeConstant); } 55 double smoothingTimeConstant() const { return m_smoothingTimeConstant; }
56 56
57 void getFloatFrequencyData(Float32Array*); 57 void getFloatFrequencyData(Float32Array*);
58 void getByteFrequencyData(Uint8Array*); 58 void getByteFrequencyData(Uint8Array*);
59 void getFloatTimeDomainData(Float32Array*); 59 void getFloatTimeDomainData(Float32Array*);
60 void getByteTimeDomainData(Uint8Array*); 60 void getByteTimeDomainData(Uint8Array*);
61 61
62 // The audio thread writes input data here. 62 // The audio thread writes input data here.
63 void writeInput(AudioBus*, size_t framesToProcess); 63 void writeInput(AudioBus*, size_t framesToProcess);
64 64
65 static const double DefaultSmoothingTimeConstant; 65 static const double DefaultSmoothingTimeConstant;
(...skipping 22 matching lines...) Expand all
88 double m_smoothingTimeConstant; 88 double m_smoothingTimeConstant;
89 89
90 // The range used when converting when using getByteFrequencyData(). 90 // The range used when converting when using getByteFrequencyData().
91 double m_minDecibels; 91 double m_minDecibels;
92 double m_maxDecibels; 92 double m_maxDecibels;
93 }; 93 };
94 94
95 } // namespace WebCore 95 } // namespace WebCore
96 96
97 #endif // RealtimeAnalyser_h 97 #endif // RealtimeAnalyser_h
OLDNEW
« no previous file with comments | « Source/modules/webaudio/AnalyserNode.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698