ui/file_manager/file_manager/foreground/js/file_manager.js - Issue 2127853002: Disable Quick View by default and add about flag to enable it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 2127853002: Disable Quick View by default and add about flag to enable it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/file_manager.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js

index 2ac4b44ea34d736e58e7865f6ff0af1cb77ce29a..08768792b24f2c4bf1774257ac5c9aae707a5461 100644

--- a/ui/file_manager/file_manager/foreground/js/file_manager.js

+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js

@@ -555,8 +555,8 @@ FileManager.prototype = /** @struct */ {

var fileListSelectionModel = /** @type {!cr.ui.ListSelectionModel} */ (

this.directoryModel_.getFileListSelection());

chrome.commandLinePrivate.hasSwitch(

- 'disable-files-quick-view', function(disabled) {

- if (!disabled) {

+ 'enable-files-quick-view', function(enabled) {

+ if (enabled) {

this.quickViewController_ = new QuickViewController(

quickView, assert(this.metadataModel_),

assert(this.selectionHandler_),

« no previous file with comments | « tools/metrics/histograms/histograms.xml ('k') | no next file » | no next file with comments »