Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2127843002: Don't perform the default action when keyCode is 229. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Don't perform the default action when keyCode is 229. The keyCode of 229 signifies that this event is being dispatched during an IME composition. Previously keyIdentifier ended up being ProcessKey but with the converstion to key events this started to be processed. Put a conditional around the event to ensure that keyCode == 229 events are discarded. This will eventually be replaced with the isComposing flag that should be added to KeyboardEvent. BUG=620794, 622158 Review-Url: https://codereview.chromium.org/2121843002 Cr-Commit-Position: refs/heads/master@{#403737} (cherry picked from commit febbb09d4df69afde4e6294a842a02e90a9cabdf) Committed: https://chromium.googlesource.com/chromium/src/+/be5ae235b1fd6fcbe8bae4500e100ae9eacca8db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 5 months ago (2016-07-06 13:39:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be5ae235b1fd6fcbe8bae4500e100ae9eacca8db.

Powered by Google App Engine
This is Rietveld 408576698