Don't perform the default action when keyCode is 229.

Don't perform the default action when keyCode is 229.

The keyCode of 229 signifies that this event is being dispatched during
an IME composition. Previously keyIdentifier ended up being ProcessKey but
with the converstion to key events this started to be processed.

Put a conditional around the event to ensure that keyCode == 229 events
are discarded. This will eventually be replaced with the isComposing
flag that should be added to KeyboardEvent.

BUG=620794, 622158
Committed: https://crrev.com/febbb09d4df69afde4e6294a842a02e90a9cabdf
Cr-Commit-Position: refs/heads/master@{#403737}

[dtapuska, 2016-07-04 21:13:33]

dtapuska@chromium.org changed reviewers:
+ bokan@chromium.org

[dtapuska, 2016-07-04 21:13:34]

Unfortunately there isn't any great tests to test the IME interaction

[bokan, 2016-07-04 22:52:06]

lgtm % comment/question

https://codereview.chromium.org/2121843002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/KeyboardEventManager.cpp (right):

https://codereview.chromium.org/2121843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/KeyboardEventManager.cpp:168: if
(event->keyCode() == 229)
Does this keyCode have a name of some kind that we could replace 229 with a more
friendly constant?

[dtapuska, 2016-07-05 02:02:33]

On 2016/07/04 22:52:06, bokan wrote:
> lgtm % comment/question
> 
>
https://codereview.chromium.org/2121843002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/input/KeyboardEventManager.cpp (right):
> 
>
https://codereview.chromium.org/2121843002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/input/KeyboardEventManager.cpp:168: if
> (event->keyCode() == 229)
> Does this keyCode have a name of some kind that we could replace 229 with a
more
> friendly constant?

done; added one to the anonymous namespace.

[dtapuska, 2016-07-05 02:02:43]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-07-05 02:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2121843002/#ps20001
(title: "Add const definition")

[commit-bot: I haz the power, 2016-07-05 02:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 02:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 02:49:42]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-07-05 02:56:56]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-07-05 02:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 03:58:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-05 03:58:31]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-05 04:00:21]

Description was changed from

==========
Don't perform the default action when keyCode is 229.

The keyCode of 229 signifies that this event is being dispatched during
an IME composition. Previously keyIdentifier ended up being ProcessKey but
with the converstion to key events this started to be processed.

Put a conditional around the event to ensure that keyCode == 229 events
are discarded. This will eventually be replaced with the isComposing
flag that should be added to KeyboardEvent.

BUG=620794, 622158
==========

to

==========
Don't perform the default action when keyCode is 229.

The keyCode of 229 signifies that this event is being dispatched during
an IME composition. Previously keyIdentifier ended up being ProcessKey but
with the converstion to key events this started to be processed.

Put a conditional around the event to ensure that keyCode == 229 events
are discarded. This will eventually be replaced with the isComposing
flag that should be added to KeyboardEvent.

BUG=620794, 622158

Committed: https://crrev.com/febbb09d4df69afde4e6294a842a02e90a9cabdf
Cr-Commit-Position: refs/heads/master@{#403737}
==========

[commit-bot: I haz the power, 2016-07-05 04:00:22]

Patchset 2 (id:??) landed as
https://crrev.com/febbb09d4df69afde4e6294a842a02e90a9cabdf
Cr-Commit-Position: refs/heads/master@{#403737}