Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2127723003:
[MD settings] do not scroll when toggling advanced menu (Closed)
|
Created:
4 years, 5 months ago by dschuyler Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] do not scroll when toggling advanced menu
This CL removes the code that will scroll to the advanced content area
when toggling the advanced menu in the side nav.
BUG=613708
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/bda0d49e07e6cb9457db06b05a09d5d14c806f6e
Cr-Commit-Position: refs/heads/master@{#406667}
Patch Set 1 #Patch Set 2 : merge with master #
Total comments: 2
Patch Set 3 : merge with master #Messages
Total messages: 22 (11 generated)
Description was changed from ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 ========== to ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2127723003/diff/20001/ash/shelf/app_list_butt... File ash/shelf/app_list_button.cc (right): https://codereview.chromium.org/2127723003/diff/20001/ash/shelf/app_list_butt... ash/shelf/app_list_button.cc:274: return views::ImageButton::ShouldEnterPushedState(event); wat
Description was changed from ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
For more details, see http://crbug.com/617627.
Cleaned up merge mistake. https://codereview.chromium.org/2127723003/diff/20001/ash/shelf/app_list_butt... File ash/shelf/app_list_button.cc (right): https://codereview.chromium.org/2127723003/diff/20001/ash/shelf/app_list_butt... ash/shelf/app_list_button.cc:274: return views::ImageButton::ShouldEnterPushedState(event); On 2016/07/08 23:32:28, Dan Beam wrote: > wat Done.
Description was changed from ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm, but just out of curiosity -- going to chrome://md-settings/advanced still scrolls to Advanced, right?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/20 19:18:53, Dan Beam wrote: > lgtm, but just out of curiosity -- going to chrome://md-settings/advanced still > scrolls to Advanced, right? It expands Advanced, but does not scroll to it. Discussed this offline: I'll look into the scrolling in a separate CL.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] do not scroll when toggling advanced menu This CL removes the code that will scroll to the advanced content area when toggling the advanced menu in the side nav. BUG=613708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bda0d49e07e6cb9457db06b05a09d5d14c806f6e Cr-Commit-Position: refs/heads/master@{#406667} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bda0d49e07e6cb9457db06b05a09d5d14c806f6e Cr-Commit-Position: refs/heads/master@{#406667}
Message was sent while issue was closed.
On 2016/07/20 20:54:06, dschuyler wrote: > On 2016/07/20 19:18:53, Dan Beam wrote: > > lgtm, but just out of curiosity -- going to chrome://md-settings/advanced > still > > scrolls to Advanced, right? > > It expands Advanced, but does not scroll to it. > Discussed this offline: I'll look into the scrolling > in a separate CL. This is a pre-existing bug already assigned to dave: crbug.com/628502 |
