chrome/browser/resources/settings/settings_main/settings_main.js - Issue 2127723003: [MD settings] do not scroll when toggling advanced menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2127723003: [MD settings] do not scroll when toggling advanced menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge with master Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_main/settings_main.js

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js

index a5a6d10c5c551c74e652076ad17224e1cae42f98..b23930bcc55a02cca9df6a3e898753257a2916a0 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.js

+++ b/chrome/browser/resources/settings/settings_main/settings_main.js

@@ -89,16 +89,6 @@ Polymer({

section: '',

subpage: [],

};

- if (this.showAdvancedPage_) {

- doWhenReady(

- function() {

- var advancedPage = this.$$('settings-advanced-page');

- return !!advancedPage && advancedPage.scrollHeight > 0;

- }.bind(this),

- function() {

- this.$$('#toggleContainer').scrollIntoView();

- }.bind(this));

- }

}.bind(this));

doWhenReady(

« no previous file with comments | « no previous file | no next file » | no next file with comments »