Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2127703007:
Don't pack gdbserver if page_align_shared_libraries is set. (Closed)
|
Created:
4 years, 5 months ago by michaelbai Modified:
4 years, 5 months ago Reviewers:
agrieve CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't pack gdbserver if page_align_shared_libraries is set.
This will make monochrome debug version works
BUG=596994
Committed: https://crrev.com/15c6b22b66f44df7d0528957b1206169a54d05a5
Cr-Commit-Position: refs/heads/master@{#404398}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
Description was changed from ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 ========== to ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 ==========
michaelbai@chromium.org changed reviewers: + agrieve@chromium.org
On 2016/07/07 19:43:38, michaelbai wrote: I think we're fine to just always stop packaging gdbserver. Our adb_gdb script just uses the one from the ndk anyways: https://cs.chromium.org/chromium/src/build/android/adb_gdb?q=adb_gdb&sq=packa...
On 2016/07/07 20:07:14, agrieve wrote: > On 2016/07/07 19:43:38, michaelbai wrote: > > I think we're fine to just always stop packaging gdbserver. Our adb_gdb script > just uses the one from the ndk anyways: > https://cs.chromium.org/chromium/src/build/android/adb_gdb?q=adb_gdb&sq=packa... OK, because other monochrome patch depends on there is no gdb server in APK, let's land this one, and I will prepare another CL to remove gdb server from APK, if it breaks something, we can just revert that patch, make sense?
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/08 02:05:17, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. sure. lgtm
The CQ bit was checked by michaelbai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 ========== to ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 ========== to ========== Don't pack gdbserver if page_align_shared_libraries is set. This will make monochrome debug version works BUG=596994 Committed: https://crrev.com/15c6b22b66f44df7d0528957b1206169a54d05a5 Cr-Commit-Position: refs/heads/master@{#404398} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/15c6b22b66f44df7d0528957b1206169a54d05a5 Cr-Commit-Position: refs/heads/master@{#404398} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
