Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2519)

Unified Diff: build/config/android/rules.gni

Issue 2127703007: Don't pack gdbserver if page_align_shared_libraries is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index a6cc4fe6edee9c2581c5260ad2f11295e97caa9f..991520325d46679e8a6b7d57222a70c9fd56e299 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1967,7 +1967,9 @@ if (enable_java_templates) {
_extra_native_libs_even_when_incremental_deps = []
assert(_extra_native_libs_even_when_incremental_deps == []) # Mark as used.
if (_native_libs_deps != []) {
- if (is_debug) {
+ # zipalign can't align gdb_server, don't pack gdbserver temporarily.
+ if (is_debug && (!defined(invoker.page_align_shared_libraries) ||
+ !invoker.page_align_shared_libraries)) {
_extra_native_libs_even_when_incremental = [ android_gdbserver ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698