Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2127703006: Permission prompts show in the top-left corner in fullscreen mode. (Closed)

Created:
4 years, 5 months ago by Matt Giuca
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Permission prompts show in the top-left corner in fullscreen mode. Previously they were shown in the center, which causes interference with the fullscreen notification. This way, they are treated more consistently both in and out of fullscreen mode. BUG=623862, 624296 TEST=On https://permission.site, click Fullscreen then Location. The location prompt should be in the top-left corner and not overlapping the "Press Esc to exit full screen" bubble. TEST=As above, but with the browser window on a secondary monitor. TEST=As above, but in Arabic or Hebrew language (should be in top-right corner). Review-Url: https://codereview.chromium.org/2109663005 Cr-Commit-Position: refs/heads/master@{#403840} (cherry picked from commit 22beefb92cb521c2aa381431b7041f2d488c7227) Committed: https://chromium.googlesource.com/chromium/src/+/2735281192ab10e3930275697983a06df06b8171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M chrome/browser/ui/views/website_settings/permissions_bubble_view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 5 months ago (2016-07-07 03:13:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2735281192ab10e3930275697983a06df06b8171.

Powered by Google App Engine
This is Rietveld 408576698