Permission prompts show in the top-left corner in fullscreen mode.

Permission prompts show in the top-left corner in fullscreen mode.

Previously they were shown in the center, which causes interference with
the fullscreen notification. This way, they are treated more
consistently both in and out of fullscreen mode.

BUG=623862, 624296
TEST=On https://permission.site, click Fullscreen then Location. The location
  prompt should be in the top-left corner and not overlapping the "Press Esc to
  exit full screen" bubble.
TEST=As above, but with the browser window on a secondary monitor.
TEST=As above, but in Arabic or Hebrew language (should be in top-right corner).

Committed: https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227
Cr-Commit-Position: refs/heads/master@{#403840}

[Matt Giuca, 2016-07-05 05:42:59]

Description was changed from

==========
Permission prompts show in the top-left corner in fullscreen mode.

Previously they were shown in the center, which causes interference with
the fullscreen notification. This way, they are treated more
consistently both in and out of fullscreen mode.

BUG=623862,624296
==========

to

==========
Permission prompts show in the top-left corner in fullscreen mode.

Previously they were shown in the center, which causes interference with
the fullscreen notification. This way, they are treated more
consistently both in and out of fullscreen mode.

BUG=623862,624296
TEST=On https://permission.site, click Fullscreen then Location. The location
  prompt should be in the top-left corner and not overlapping the "Press Esc to
  exit full screen" bubble.
TEST=As above, but with the browser window on a secondary monitor.
TEST=As above, but in Arabic or Hebrew language (should be in top-right corner).
==========

[Matt Giuca, 2016-07-05 05:44:19]

mgiuca@chromium.org changed reviewers:
+ benwells@chromium.org

[Matt Giuca, 2016-07-05 05:44:20]

https://codereview.chromium.org/2109663005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
(right):

https://codereview.chromium.org/2109663005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:365:
SetAnchorView(anchor_view);
This change was necessary to properly respond to the |anchor_view| becoming null
(which now calls SetAnchorView(nullptr)). Previously, if |anchor_view| became
null it would remain set to its old value which means it will be stuck anchored
to something.

[benwells, 2016-07-06 01:08:53]

lgtm

https://codereview.chromium.org/2109663005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
(right):

https://codereview.chromium.org/2109663005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:365:
SetAnchorView(anchor_view);
On 2016/07/05 05:44:20, Matt Giuca wrote:
> This change was necessary to properly respond to the |anchor_view| becoming
null
> (which now calls SetAnchorView(nullptr)). Previously, if |anchor_view| became
> null it would remain set to its old value which means it will be stuck
anchored
> to something.

Acknowledged.

[Matt Giuca, 2016-07-06 01:38:07]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-07-06 01:38:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 02:25:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 02:25:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 02:27:22]

Description was changed from

==========
Permission prompts show in the top-left corner in fullscreen mode.

Previously they were shown in the center, which causes interference with
the fullscreen notification. This way, they are treated more
consistently both in and out of fullscreen mode.

BUG=623862,624296
TEST=On https://permission.site, click Fullscreen then Location. The location
  prompt should be in the top-left corner and not overlapping the "Press Esc to
  exit full screen" bubble.
TEST=As above, but with the browser window on a secondary monitor.
TEST=As above, but in Arabic or Hebrew language (should be in top-right corner).
==========

to

==========
Permission prompts show in the top-left corner in fullscreen mode.

Previously they were shown in the center, which causes interference with
the fullscreen notification. This way, they are treated more
consistently both in and out of fullscreen mode.

BUG=623862,624296
TEST=On https://permission.site, click Fullscreen then Location. The location
  prompt should be in the top-left corner and not overlapping the "Press Esc to
  exit full screen" bubble.
TEST=As above, but with the browser window on a secondary monitor.
TEST=As above, but in Arabic or Hebrew language (should be in top-right corner).

Committed: https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227
Cr-Commit-Position: refs/heads/master@{#403840}
==========

[commit-bot: I haz the power, 2016-07-06 02:27:23]

Patchset 2 (id:??) landed as
https://crrev.com/22beefb92cb521c2aa381431b7041f2d488c7227
Cr-Commit-Position: refs/heads/master@{#403840}