Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2127633002: [gn] Remove an assert that's hard to adhere. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Remove an assert that's hard to adhere. We don't explicitly switch off v8_use_external_startup_data when not using a snapshot. Therefore we also shouldn't assert this. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/0ff1ca3f1fb08b6e3dc58d2192f9171c143ec1e5 Cr-Commit-Position: refs/heads/master@{#37542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Achenbach
PTAL. Repairing https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20builder/builds/13957/steps/generate_build_files%20with%20gn%20%28fyi%29/logs/stdio
4 years, 5 months ago (2016-07-05 15:27:32 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-05 15:31:58 UTC) #5
vogelheim
lgtm
4 years, 5 months ago (2016-07-06 07:28:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127633002/1
4 years, 5 months ago (2016-07-06 07:50:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 07:53:09 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 07:53:12 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 07:55:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ff1ca3f1fb08b6e3dc58d2192f9171c143ec1e5
Cr-Commit-Position: refs/heads/master@{#37542}

Powered by Google App Engine
This is Rietveld 408576698