BUILD.gn - Issue 2127633002: [gn] Remove an assert that's hard to adhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2127633002: [gn] Remove an assert that's hard to adhere. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index cb2e7dcc376e932d5166dc6973d90efb043da984..9ccd5c2646a123be8612572bab7b32c4287cb66e 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -668,7 +668,7 @@ source_set("v8_maybe_snapshot") {

":v8_snapshot",

]

} else {

- assert(!v8_use_external_startup_data)

+ # Ignore v8_use_external_startup_data setting if no snapshot is used.

public_deps = [

":v8_nosnapshot",

]

« no previous file with comments | « no previous file | no next file » | no next file with comments »