V8: Get build environment from MB

V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516, 616035
Committed: https://chromium.googlesource.com/chromium/tools/build/+/f9f6d442add21c92080b06a3c40c191b50148b09

[Michael Achenbach, 2016-07-05 14:14:27]

Description was changed from

==========
V8: Get build environment from MB

BUG=
==========

to

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516
==========

[Michael Achenbach, 2016-07-05 14:33:55]

Description was changed from

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516
==========

to

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=474921,605516
==========

[Michael Achenbach, 2016-07-05 14:33:55]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2016-07-05 14:36:48]

PTAL

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/api.py (left):

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/api.py:316: if 'GYP_DEFINES' in
build_environment:
This part moves to the update_build_environment method.

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/api.py:396: def _gyp_defines_to_dict(self,
gyp_defines):
This is just extracted one level up. No code changes.

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/api.py:426: '^(?:set
)?GYP_([^=]*)=(?:(?:\'(.*)\')|(?:(.*)))$', mb_output, re.M):
Regexp is unchanged except for GYP_([^=]*). This adds an extra match group in
the beginning. This will also match, e.g. GYP_CROSSCOMPILE in
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/...

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/api.py:435: match = re.search(r'Writing
"""\\?\s*(.*)""" to ', mb_output, re.S)
This matches e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/bu...

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/api.py:443: def _compare_gyp_defines(self,
mb_output):
This method will go away soon.

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
File scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
(right):

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json:388:
"GYP_DEFINES": "target_arch=x64 cool_flag=a=1"
The expectations change everywhere to whatever the step_test_data defines now.

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
File
scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
(right):

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json:230:
"parent_build_environment": {},
This bot doesn't use MB. We just switch off the feature now.

[Michael Achenbach, 2016-07-05 14:37:04]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 14:37:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 14:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 14:41:18]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-07-05 14:59:20]

lgtm

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
File
scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
(right):

https://codereview.chromium.org/2127573003/diff/20001/scripts/slave/recipes/v...
scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json:230:
"parent_build_environment": {},
On 2016/07/05 14:36:48, Michael Achenbach wrote:
> This bot doesn't use MB. We just switch off the feature now.

Acknowledged.

[Michael Achenbach, 2016-07-05 15:01:32]

Description was changed from

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=474921,605516
==========

to

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516,616035
==========

[Michael Achenbach, 2016-07-05 15:01:58]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-05 15:02:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 15:06:12]

Description was changed from

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516,616035
==========

to

==========
V8: Get build environment from MB

Before MB, the build environment was hard-coded by
configurations on the infra side. After moving to MB, the
build environment is set dynamically in a recipe step.

The build environment is written to a property and passed to
testers to be presented to the user on build failures. This
CL makes that work with MB, both if it's a gyp or gn
environment.

BUG=605516,616035

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f9f6d442add21c92080b...
==========

[commit-bot: I haz the power, 2016-07-05 15:06:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/f9f6d442add21c92080b...