scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json - Issue 2127573003: V8: Get build environment from MB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json

Issue 2127573003: V8: Get build environment from MB (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: V8: Get build environment from MB Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json ('K') | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json » ('j') | scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json

index a3134664e44ca16c2c61503f636cbffd02b31f07..55afacf008404010334820ac4de344290b315787 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json

@@ -453,8 +453,7 @@

"@@@STEP_LOG_LINE@test-name@Command: d8 test.js@@@",

"@@@STEP_LOG_LINE@test-name@@@@",

"@@@STEP_LOG_LINE@test-name@Build environment:@@@",

- "@@@STEP_LOG_LINE@test-name@ GYP_DEFINES: target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0@@@",

- "@@@STEP_LOG_LINE@test-name@ GYP_GENERATORS: ninja@@@",

+ "@@@STEP_LOG_LINE@test-name@ GYP_DEFINES: target_arch=x64 cool_flag=a=1@@@",

"@@@STEP_LOG_LINE@test-name@@@@",

"@@@STEP_LOG_LINE@test-name@Run #1@@@",

"@@@STEP_LOG_LINE@test-name@Exit code: 1@@@",