Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2127463002: Revert of Move UndoStack from Page to Editor (Closed)

Created:
4 years, 5 months ago by Kunihiko Sakamoto
Modified:
4 years, 5 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move UndoStack from Page to Editor (patchset #4 id:60001 of https://codereview.chromium.org/2110543008/ ) Reason for revert: speculative revert to see whether this caused crbug.com/625736 Original issue's description: > Move UndoStack from Page to Editor > > Blink currently maintains per-page undo stacks, leading to: > - Security risks. A frame can directly manipulate content of another frame > by running document.execCommand('undo'), allowing Javascript to bypass > frame and even origin boundaries. > - Inconsistent behaviors. Without OOPIF, all changes in a page can be undone > by repeatedly invoking keyboard undo (CTRL+Z); With OOPIF, only those changes > in the focused frame and its same-origin frames can be undone. > > Redos have analogous defects. > > This patch changes UndoStack from per-page to per-frame, so that undos and > redos are consistently resolved by the frame where script is run or which > gets focused. > > This patch also removes |UndoStack::didUnloadFrame()| since its only purpose > is to filter out the undo steps for a particular frame, which no longer makes > sense after undo stacks are made per-frame. > > BUG=349272, 549334 > TEST=editing/undo/undo-iframe-location-change.html > > Committed: https://crrev.com/6447f384cf6d95f70475798e3fd45b689316ce50 > Cr-Commit-Position: refs/heads/master@{#403653} TBR=tkent@chromium.org,yosin@chromium.org,xiaochengh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=349272, 549334 Committed: https://crrev.com/4fef5557cbf3bc2dbcf46ea386ef9243860be835 Cr-Commit-Position: refs/heads/master@{#403742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html View 2 chunks +43 lines, -22 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 7 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
Created Revert of Move UndoStack from Page to Editor
4 years, 5 months ago (2016-07-05 05:01:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127463002/1
4 years, 5 months ago (2016-07-05 05:01:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 05:02:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fef5557cbf3bc2dbcf46ea386ef9243860be835 Cr-Commit-Position: refs/heads/master@{#403742}
4 years, 5 months ago (2016-07-05 05:03:34 UTC) #6
tkent
4 years, 5 months ago (2016-07-05 05:13:19 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698