Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/vm/parser.cc

Issue 21274007: Set local function type as uninstantiated when applicable (fix issue 12127). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/function_subtype_local6_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 25677)
+++ runtime/vm/parser.cc (working copy)
@@ -5369,6 +5369,10 @@
function_type.set_malformed_error(error);
}
+ // The function type was initially marked as instantiated, but it may
zra 2013/07/31 21:32:33 Why might it be wrong the first time?
regis 2013/07/31 23:16:44 See comment on line 5269. The local variable and i
+ // actually be uninstantiated.
+ function_type.ResetIsFinalized();
+
// The function variable type should have been patched above.
ASSERT((function_variable == NULL) ||
(function_variable->type().raw() == function_type.raw()));
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/function_subtype_local6_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698