Set local function type as uninstantiated when applicable (fix issue 12127).

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 5351 matching lines @@
     // Patch the function type of the variable now that the signature is known.
     function_type.set_type_class(signature_class);
     function_type.set_arguments(signature_type_arguments);
 
     // Mark the function type as malformed if the signature type is malformed.
     if (signature_type.IsMalformed()) {
       const Error& error = Error::Handle(signature_type.malformed_error());
       function_type.set_malformed_error(error);
     }
 
+    // The function type was initially marked as instantiated, but it may

[zra, 2013/07/31 21:32:33]

Why might it be wrong the first time?

[regis, 2013/07/31 23:16:44]

See comment on line 5269. The local variable and its still unknown type must be
entered in the symbol table before parsing the function signature.

+    // actually be uninstantiated.
+    function_type.ResetIsFinalized();
+
     // The function variable type should have been patched above.
     ASSERT((function_variable == NULL) ||
            (function_variable->type().raw() == function_type.raw()));
   }
 
   // The code generator does not compile the closure function when visiting
   // a ClosureNode. The generated code allocates a new Closure object containing
   // the current context. The type of the Closure object refers to the closure
   // function, which will be compiled on first invocation of the closure object.
   // Therefore, we ignore the parsed default_parameter_values and the
@@ skipping 4868 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart