LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html - Issue 21274004: Fix Document leak from NodeFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: don't print numberOfLiveDocuments when test passed Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/leak-document-with-selection-inside-expected.txt ('k') | LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

diff --git a/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html b/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

new file mode 100644

index 0000000000000000000000000000000000000000..c3a1cb82aecb20f75abd700a5d5530ddb209cd1e

--- /dev/null

+++ b/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

@@ -0,0 +1,34 @@

+<!DOCTYPE html>

+<html>

+<body>

+<script src="../../js/resources/js-test-pre.js"></script>

+<script>

+ var callbackWasTriggered = false;

+ var callback = function(node) {

+ callbackWasTriggered = true;

+ return NodeFilter.FILTER_ACCEPT;

+ };

+ var nodeIterator = document.createNodeIterator(document, NodeFilter.SHOW_ELEMENT, callback, false);

+ var callbackObservation = internals.observeGC(callback);

+ callback = null;

+ var nodeFilterObservation = internals.observeGC(nodeIterator.filter);

+ var nodeIteratorObservation = internals.observeGC(nodeIterator);

+ gc();

+ shouldBeFalse('nodeFilterObservation.wasCollected');

+ shouldBeFalse('callbackObservation.wasCollected');

+ nodeIterator.nextNode();

+ shouldBeTrue('callbackWasTriggered');

+ nodeIterator = null;

+ gc();

+ shouldBeTrue('nodeIteratorObservation.wasCollected');

+ shouldBeTrue('nodeFilterObservation.wasCollected');

+ shouldBeTrue('callbackObservation.wasCollected');

+</script>

+<script src="../../js/resources/js-test-post.js"></script>

+</body>

+</html>