LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html - Issue 21274004: Fix Document leak from NodeFilter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: don't print numberOfLiveDocuments when test passed Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../js/resources/js-test-pre.js"></script>

	5 <script>

	6 var callbackWasTriggered = false;

	7

	8 var callback = function(node) {

	9 callbackWasTriggered = true;

	10 return NodeFilter.FILTER_ACCEPT;

	11 };

	12 var nodeIterator = document.createNodeIterator(document, NodeFilter.SHOW_ELE MENT, callback, false);

	13

	14 var callbackObservation = internals.observeGC(callback);

	15 callback = null;

	16 var nodeFilterObservation = internals.observeGC(nodeIterator.filter);

	17 var nodeIteratorObservation = internals.observeGC(nodeIterator);

	18

	19 gc();

	20 shouldBeFalse('nodeFilterObservation.wasCollected');

	21 shouldBeFalse('callbackObservation.wasCollected');

	22

	23 nodeIterator.nextNode();

	24 shouldBeTrue('callbackWasTriggered');

	25

	26 nodeIterator = null;

	27 gc();

	28 shouldBeTrue('nodeIteratorObservation.wasCollected');

	29 shouldBeTrue('nodeFilterObservation.wasCollected');

	30 shouldBeTrue('callbackObservation.wasCollected');

	31 </script>

	32 <script src="../../js/resources/js-test-post.js"></script>

	33 </body>

	34 </html>

OLD	NEW