Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.h

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add assertions to wrap Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8NodeFilterCondition.h
diff --git a/Source/bindings/v8/V8NodeFilterCondition.h b/Source/bindings/v8/V8NodeFilterCondition.h
index 3314a1aca4bde54a4308c150cafb9141be17794f..87bf5476d0c5a8d2377be4b6b2f52748820a550d 100644
--- a/Source/bindings/v8/V8NodeFilterCondition.h
+++ b/Source/bindings/v8/V8NodeFilterCondition.h
@@ -43,9 +43,9 @@ class ScriptState;
class V8NodeFilterCondition : public NodeFilterCondition {
haraken 2013/08/01 13:32:20 Would you add a comment about the relationship bet
kouhei (in TOK) 2013/08/02 03:26:57 Done.
public:
- static PassRefPtr<V8NodeFilterCondition> create(v8::Handle<v8::Value> filter)
+ static PassRefPtr<V8NodeFilterCondition> create(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner)
{
- return adoptRef(new V8NodeFilterCondition(filter));
+ return adoptRef(new V8NodeFilterCondition(filter, owner));
}
virtual ~V8NodeFilterCondition();
@@ -53,7 +53,9 @@ public:
virtual short acceptNode(ScriptState*, Node*) const;
private:
- explicit V8NodeFilterCondition(v8::Handle<v8::Value> filter);
+ explicit V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner);
haraken 2013/08/01 13:32:20 Nit: explicit isn't needed.
kouhei (in TOK) 2013/08/02 03:26:57 Done.
+
+ static void makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Value>*, V8NodeFilterCondition*);
ScopedPersistent<v8::Value> m_filter;
};

Powered by Google App Engine
This is Rietveld 408576698