Source/bindings/v8/custom/V8DocumentCustom.cpp - Issue 21274004: Fix Document leak from NodeFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentCustom.cpp

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add assertions to wrap Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentCustom.cpp b/Source/bindings/v8/custom/V8DocumentCustom.cpp

index 7431fd7f9cb22815875354b31f2d902f20dd4adc..e9865103e5768d63e961e0a44afb72a6fb032cab 100644

--- a/Source/bindings/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentCustom.cpp

@@ -35,9 +35,12 @@

#include "V8DOMImplementation.h"

#include "V8HTMLDocument.h"

#include "V8Node.h"

+#include "V8NodeFilter.h"

+#include "V8NodeIterator.h"

#include "V8SVGDocument.h"

#include "V8Touch.h"

#include "V8TouchList.h"

+#include "V8TreeWalker.h"

#include "V8WebGLRenderingContext.h"

#include "V8XPathNSResolver.h"

#include "V8XPathResult.h"

@@ -45,6 +48,8 @@

#include "bindings/v8/ScriptController.h"

#include "bindings/v8/V8Binding.h"

#include "bindings/v8/V8DOMWrapper.h"

+#include "bindings/v8/V8HiddenPropertyName.h"

+#include "bindings/v8/V8NodeFilterCondition.h"

haraken 2013/08/01 13:32:20 These #includes will be no longer necessary.

kouhei (in TOK) 2013/08/02 03:26:57 Done.

#include "bindings/v8/V8WindowShell.h"

#include "bindings/v8/custom/V8CustomXPathNSResolver.h"

#include "core/dom/Document.h"