LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html - Issue 21274004: Fix Document leak from NodeFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add TreeWalker leak test Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html ('K') | « LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document-expected.txt ('k') | LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document-expected.txt » ('j') | Source/bindings/v8/custom/V8DocumentCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

diff --git a/LayoutTests/editing/selection/leak-document-with-selection-inside.html b/LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

similarity index 82%

copy from LayoutTests/editing/selection/leak-document-with-selection-inside.html

copy to LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

index 763fac38f7bca997a247ef902442f4d23568fb89..d76aeb0b5c8788a8b3f6ca4dd5598648a38318d3 100644

--- a/LayoutTests/editing/selection/leak-document-with-selection-inside.html

+++ b/LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

@@ -1,6 +1,6 @@

<html>

<head>

-<script src="../../fast/js/resources/js-test-pre.js"></script>

+<script src="../../js/resources/js-test-pre.js"></script>

</head>

<body>

<span>This test only runs on DumpRenderTree, as it requires existence of window.internals and cross-domain resource access check disabled.</span>

@@ -42,8 +42,8 @@

}

frame.src = 'about:blank';

}

- frame.src='data:text/html;charset=utf-8,<span id="t"></span>';

+ frame.src='data:text/html;charset=utf-8,<script>keep = document.createTreeWalker(document, NodeFilter.SHOW_ELEMENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false);</script'+'>';

</script>

- <script src="../../fast/js/resources/js-test-post.js"></script>

+ <script src="../../js/resources/js-test-post.js"></script>

</body>

</html>