Chromium Code Reviews Chromium Code Reviews
Issue 21274004:
Fix Document leak from NodeFilter. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html |
| diff --git a/LayoutTests/editing/selection/leak-document-with-selection-inside.html b/LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html |
| similarity index 82% |
| copy from LayoutTests/editing/selection/leak-document-with-selection-inside.html |
| copy to LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html |
| index 763fac38f7bca997a247ef902442f4d23568fb89..c7128a312c0349269bf64b3090ad14e7637d6d14 100644 |
| --- a/LayoutTests/editing/selection/leak-document-with-selection-inside.html |
| +++ b/LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html |
| @@ -1,6 +1,6 @@ |
| <html> |
| <head> |
| -<script src="../../fast/js/resources/js-test-pre.js"></script> |
| +<script src="../../js/resources/js-test-pre.js"></script> |
| </head> |
| <body> |
| <span>This test only runs on DumpRenderTree, as it requires existence of window.internals and cross-domain resource access check disabled.</span> |
| @@ -42,8 +42,8 @@ |
| } |
| frame.src = 'about:blank'; |
| } |
| - frame.src='data:text/html;charset=utf-8,<span id="t"></span>'; |
| + frame.src='data:text/html;charset=utf-8,<script>keep = document.createNodeIterator(document, NodeFilter.SHOW_ELEMENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false);</script'+'>'; |
|
haraken
2013/08/01 03:44:15
Instead of adding one test file for one leak you d
dominicc (has gone to gerrit)
2013/08/01 04:51:12
Duplicating this is a shame, can you just put a do
kouhei (in TOK)
2013/08/01 05:09:58
Done. Unified to fast/dom/leak-document.html
|
| </script> |
| - <script src="../../fast/js/resources/js-test-post.js"></script> |
| + <script src="../../js/resources/js-test-post.js"></script> |
| </body> |
| </html> |
