LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html - Issue 21274004: Fix Document leak from NodeFilter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document.html

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add TreeWalker leak test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html ('K') | « LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect-expected.txt ('k') | LayoutTests/fast/dom/NodeIterator/NodeIterator-leak-document-expected.txt » ('j') | Source/bindings/v8/custom/V8DocumentCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../fast/js/resources/js-test-pre.js"></script>	3 <script src="../../js/resources/js-test-pre.js"></script>

4 </head>	4 </head>

5 <body>	5 <body>

6 <span>This test only runs on DumpRenderTree, as it requires existence of win dow.internals and cross-domain resource access check disabled.</span>	6 <span>This test only runs on DumpRenderTree, as it requires existence of win dow.internals and cross-domain resource access check disabled.</span>

7 <iframe id="f" src='about:blank'></iframe>	7 <iframe id="f" src='about:blank'></iframe>

8 <script>	8 <script>

9 description("This test asserts that document doesn't leak when a selecti on is created inside the document.");	9 description("This test asserts that document doesn't leak when a selecti on is created inside the document.");

10	10

11 jsTestIsAsync = true;	11 jsTestIsAsync = true;

12 if (!window.internals)	12 if (!window.internals)

13 finishJSTest();	13 finishJSTest();

(...skipping 21 matching lines...) Expand all Loading...
35	35

36 frame.onload = function() {	36 frame.onload = function() {

37 // document unloaded...	37 // document unloaded...

38	38

39 numberOfDocumentsAfter = countNumberOfLiveDocuments();	39 numberOfDocumentsAfter = countNumberOfLiveDocuments();

40 shouldBe("numberOfDocumentsAfter", "numberOfDocumentsBefore");	40 shouldBe("numberOfDocumentsAfter", "numberOfDocumentsBefore");

41 finishJSTest();	41 finishJSTest();

42 }	42 }

43 frame.src = 'about:blank';	43 frame.src = 'about:blank';

44 }	44 }

45 frame.src='data:text/html;charset=utf-8,<span id="t"></span>';	45 frame.src='data:text/html;charset=utf-8,<script>keep = document.createNo deIterator(document, NodeFilter.SHOW_ELEMENT, function(node) { return NodeFilter .SHOW_ELEMENT; }, false);</script'+'>';
	haraken 2013/08/01 03:44:15 Instead of adding one test file for one leak you d Instead of adding one test file for one leak you detected, you can prepare fast/dom/leak-document.html and put all tests into the file. dominicc (has gone to gerrit) 2013/08/01 04:51:12 Duplicating this is a shame, can you just put a do Duplicating this is a shame, can you just put a document in resources and src= to that? kouhei (in TOK) 2013/08/01 05:09:58 Done. Unified to fast/dom/leak-document.html Show quoted text On 2013/08/01 03:44:15, haraken wrote: > > Instead of adding one test file for one leak you detected, you can prepare > fast/dom/leak-document.html and put all tests into the file. Done. Unified to fast/dom/leak-document.html
46 </script>	46 </script>

47 <script src="../../fast/js/resources/js-test-post.js"></script>	47 <script src="../../js/resources/js-test-post.js"></script>

48 </body>	48 </body>

49 </html>	49 </html>

OLD	NEW