Open hyperlinks in PDF in a new tab when middle mouse clicking.

pdf/pdfium/pdfium_page.h

Index: pdf/pdfium/pdfium_page.h
diff --git a/pdf/pdfium/pdfium_page.h b/pdf/pdfium/pdfium_page.h
index fa94ed96a081339f0900921f1e6dd97b9df8add8..aa71e5a7b8ea71575e6c35ca1e6c400b58051fef 100644
--- a/pdf/pdfium/pdfium_page.h
+++ b/pdf/pdfium/pdfium_page.h
@@ -96,6 +96,8 @@ class PDFiumPage {
      calculated_links_ = calculated_links;
   }
 
+  std::vector<pp::Rect> GetLinkRects();

[Lei Zhang, 2016/07/08 18:02:36]

nit: Put this above the simple accessors, around line 89.

[jaepark, 2016/07/08 20:58:16]

Done.

+
  private:
   // Returns a link index if the given character index is over a link, or -1
   // otherwise.
@@ -112,6 +114,8 @@ class PDFiumPage {
   // Returns target associated with a destination.
   Area GetDestinationTarget(FPDF_DEST destination, LinkTarget* target) const;
 
+  pp::Rect UnionLinkCharRects(const std::vector<pp::Rect> rects);

[Lei Zhang, 2016/07/08 18:02:36]

This method doesn't use any class members. Put it in pdfium_page.cc in an
anonymous namespace? Thus you don't have to expose it all in via the header.

[Lei Zhang, 2016/07/08 18:02:36]

The parameter should be passed by const ref, not by value.

[jaepark, 2016/07/08 20:58:17]

Done.

[jaepark, 2016/07/08 20:58:17]

Done.

+
   class ScopedLoadCounter {
    public:
     explicit ScopedLoadCounter(PDFiumPage* page);