Open hyperlinks in PDF in a new tab when middle mouse clicking.

pdf/pdfium/pdfium_page.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PDF_PDFIUM_PDFIUM_PAGE_H_
 #define PDF_PDFIUM_PDFIUM_PAGE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 78 matching lines @@
 
   int index() const { return index_; }
   pp::Rect rect() const { return rect_; }
   void set_rect(const pp::Rect& r) { rect_ = r; }
   bool available() const { return available_; }
   void set_available(bool available) { available_ = available; }
   void set_calculated_links(bool calculated_links) {
      calculated_links_ = calculated_links;
   }
 
+  std::vector<pp::Rect> GetLinkRects();

[Lei Zhang, 2016/07/08 18:02:36]

nit: Put this above the simple accessors, around line 89.

[jaepark, 2016/07/08 20:58:16]

Done.

+
  private:
   // Returns a link index if the given character index is over a link, or -1
   // otherwise.
   int GetLink(int char_index, LinkTarget* target);
   // Returns the link indices if the given rect intersects a link rect, or an
   // empty vector otherwise.
   std::vector<int> GetLinks(pp::Rect text_area,
                             std::vector<LinkTarget>* targets);
   // Calculate the locations of any links on the page.
   void CalculateLinks();
   // Returns link type and target associated with a link. Returns
   // NONSELECTABLE_AREA if link detection failed.
   Area GetLinkTarget(FPDF_LINK link, LinkTarget* target) const;
   // Returns target associated with a destination.
   Area GetDestinationTarget(FPDF_DEST destination, LinkTarget* target) const;
 
+  pp::Rect UnionLinkCharRects(const std::vector<pp::Rect> rects);

[Lei Zhang, 2016/07/08 18:02:36]

This method doesn't use any class members. Put it in pdfium_page.cc in an
anonymous namespace? Thus you don't have to expose it all in via the header.

[Lei Zhang, 2016/07/08 18:02:36]

The parameter should be passed by const ref, not by value.

[jaepark, 2016/07/08 20:58:17]

Done.

[jaepark, 2016/07/08 20:58:17]

Done.

+
   class ScopedLoadCounter {
    public:
     explicit ScopedLoadCounter(PDFiumPage* page);
     ~ScopedLoadCounter();
 
    private:
     PDFiumPage* const page_;
   };
 
   struct Link {
@@ skipping 12 matching lines @@
   int loading_count_;
   pp::Rect rect_;
   bool calculated_links_;
   std::vector<Link> links_;
   bool available_;
 };
 
 }  // namespace chrome_pdf
 
 #endif  // PDF_PDFIUM_PDFIUM_PAGE_H_