Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
CC:
avayvod+watch_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, devtools-reviews_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jbudorick+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jochen+watch_chromium.org, johnme+watch_chromium.org, jshin+watch_chromium.org, kinuko+fileapi, mikecase+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-notifications_chromium.org, nhiroki, nona+watch_chromium.org, ortuno+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, pfeldman, posciak+watch_chromium.org, rouslan+autofill_chromium.org, samuong+watch_chromium.org, scheib+watch_chromium.org, shuchen+watch_chromium.org, sync-reviews_chromium.org, tfarina, tzik, vabr+watchlistautofill_chromium.org, xjz+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::StartWith() in more places when appropriate. TBR=thakis@chromium.org Committed: https://crrev.com/30d94e4734a194c1524403c1f2edb222ffe35531 Cr-Commit-Position: refs/heads/master@{#405308}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : Address comments, fix more nits #

Total comments: 1

Patch Set 5 : Fix build #

Total comments: 2

Patch Set 6 : Fix build, fix error #

Total comments: 2

Patch Set 7 : data_reduction_proxy #

Patch Set 8 : rebase #

Patch Set 9 : rebase, resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -197 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 2 3 4 5 1 chunk +40 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 2 3 3 chunks +37 lines, -33 lines 0 comments Download
M chrome/browser/devtools/device/android_device_info_query.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +19 lines, -16 lines 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/browser_info.cc View 1 2 3 4 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_desktop_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/test/ppapi/ppapi_filechooser_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/utility/media_galleries/picasa_albums_indexer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 3 chunks +6 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 2 3 4 5 6 7 chunks +24 lines, -29 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_uuid.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/common/extension_l10n_util.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/gservices_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/key_systems.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 2 3 4 5 6 7 8 2 chunks +13 lines, -10 lines 0 comments Download
M storage/common/fileapi/file_system_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/display_util_x11.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (15 generated)
Lei Zhang
I found more.
4 years, 5 months ago (2016-07-11 17:33:11 UTC) #2
lazyboy
Great, thanks. LGTM https://codereview.chromium.org/2127373006/diff/20001/chrome/browser/devtools/device/adb/mock_adb_server.cc File chrome/browser/devtools/device/adb/mock_adb_server.cc (right): https://codereview.chromium.org/2127373006/diff/20001/chrome/browser/devtools/device/adb/mock_adb_server.cc#newcode575 chrome/browser/devtools/device/adb/mock_adb_server.cc:575: base::SplitString(command.substr(strlen(kShellPrefix)), "\n", Tangential: Do you not ...
4 years, 5 months ago (2016-07-11 20:34:54 UTC) #3
Lei Zhang
https://codereview.chromium.org/2127373006/diff/20001/chrome/browser/devtools/device/adb/mock_adb_server.cc File chrome/browser/devtools/device/adb/mock_adb_server.cc (right): https://codereview.chromium.org/2127373006/diff/20001/chrome/browser/devtools/device/adb/mock_adb_server.cc#newcode575 chrome/browser/devtools/device/adb/mock_adb_server.cc:575: base::SplitString(command.substr(strlen(kShellPrefix)), "\n", On 2016/07/11 20:34:54, lazyboy wrote: > Tangential: ...
4 years, 5 months ago (2016-07-11 21:01:47 UTC) #4
lazyboy
still lgtm https://codereview.chromium.org/2127373006/diff/60001/chrome/test/chromedriver/chrome/browser_info.cc File chrome/test/chromedriver/chrome/browser_info.cc (right): https://codereview.chromium.org/2127373006/diff/60001/chrome/test/chromedriver/chrome/browser_info.cc#newcode20 chrome/test/chromedriver/chrome/browser_info.cc:20: const kVersionPrefixLen = sizeof(kVersionPrefix) - 1; type
4 years, 5 months ago (2016-07-11 21:18:25 UTC) #7
Reilly Grant (use Gerrit)
device and extensions lgtm
4 years, 5 months ago (2016-07-11 21:25:01 UTC) #8
piman
https://codereview.chromium.org/2127373006/diff/80001/content/shell/renderer/layout_test/blink_test_runner.cc File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2127373006/diff/80001/content/shell/renderer/layout_test/blink_test_runner.cc#newcode559 content/shell/renderer/layout_test/blink_test_runner.cc:559: result = result.substr(0, kFileLen) + result.substr(kFileLen); I think the ...
4 years, 5 months ago (2016-07-11 21:29:54 UTC) #9
bbudge
pepper / nacl lgtm
4 years, 5 months ago (2016-07-11 21:31:37 UTC) #10
Lei Zhang
https://codereview.chromium.org/2127373006/diff/80001/content/shell/renderer/layout_test/blink_test_runner.cc File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2127373006/diff/80001/content/shell/renderer/layout_test/blink_test_runner.cc#newcode559 content/shell/renderer/layout_test/blink_test_runner.cc:559: result = result.substr(0, kFileLen) + result.substr(kFileLen); On 2016/07/11 21:29:54, ...
4 years, 5 months ago (2016-07-11 22:19:48 UTC) #11
piman
content/ lgtm
4 years, 5 months ago (2016-07-11 22:24:48 UTC) #12
hubbe
media/* lgtm
4 years, 5 months ago (2016-07-11 22:37:38 UTC) #13
Mathieu
lgtm components/autofill
4 years, 5 months ago (2016-07-12 13:43:01 UTC) #14
Nicolas Zea
sync + gcm LGTM
4 years, 5 months ago (2016-07-12 19:06:32 UTC) #15
megjablon
https://chromiumcodereview.appspot.com/2127373006/diff/100001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://chromiumcodereview.appspot.com/2127373006/diff/100001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode97 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:97: bool IsIncludedInLoFiEnabledFieldTrial() { Use StartsWith for this and the ...
4 years, 5 months ago (2016-07-13 00:05:53 UTC) #16
Lei Zhang
https://codereview.chromium.org/2127373006/diff/100001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/2127373006/diff/100001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode97 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:97: bool IsIncludedInLoFiEnabledFieldTrial() { On 2016/07/13 00:05:53, megjablon wrote: > ...
4 years, 5 months ago (2016-07-13 16:15:32 UTC) #17
megjablon
lgtm
4 years, 5 months ago (2016-07-13 17:30:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127373006/140001
4 years, 5 months ago (2016-07-13 18:00:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217396)
4 years, 5 months ago (2016-07-13 18:08:25 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127373006/160001
4 years, 5 months ago (2016-07-13 22:20:19 UTC) #31
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 5 months ago (2016-07-13 22:36:53 UTC) #33
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:39:16 UTC) #35
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/30d94e4734a194c1524403c1f2edb222ffe35531
Cr-Commit-Position: refs/heads/master@{#405308}

Powered by Google App Engine
This is Rietveld 408576698