Use base::StartWith() in more places when appropriate.

chrome/browser/android/contextualsearch/contextual_search_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h"
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/command_line.h"
@@ skipping 409 matching lines @@
 // the value of the given parameters.
 void ContextualSearchDelegate::DecodeSearchTermFromJsonResponse(
     const std::string& response,
     std::string* search_term,
     std::string* display_text,
     std::string* alternate_term,
     std::string* prevent_preload,
     int* mention_start,
     int* mention_end,
     std::string* lang) {
-  bool contains_xssi_escape = response.find(kXssiEscape) == 0;
+  bool contains_xssi_escape =
+      base::StartsWith(response, kXssiEscape, base::CompareCase::SENSITIVE);
   const std::string& proper_json =
-      contains_xssi_escape ? response.substr(strlen(kXssiEscape)) : response;
+      contains_xssi_escape ? response.substr(sizeof(kXssiEscape) - 1)
+                           : response;
   JSONStringValueDeserializer deserializer(proper_json);
-  std::unique_ptr<base::Value> root = deserializer.Deserialize(NULL, NULL);
+  std::unique_ptr<base::Value> root =
+      deserializer.Deserialize(nullptr, nullptr);
+  std::unique_ptr<base::DictionaryValue> dict =
+      base::DictionaryValue::From(std::move(root));
+  if (!dict)
+    return;
 
-  if (root.get() != NULL && root->IsType(base::Value::TYPE_DICTIONARY)) {
-    base::DictionaryValue* dict =
-        static_cast<base::DictionaryValue*>(root.get());
-    dict->GetString(kContextualSearchPreventPreload, prevent_preload);
-    dict->GetString(kContextualSearchResponseSearchTermParam, search_term);
-    dict->GetString(kContextualSearchResponseLanguageParam, lang);
-    // For the display_text, if not present fall back to the "search_term".
-    if (!dict->GetString(kContextualSearchResponseDisplayTextParam,
-                         display_text)) {
-      *display_text = *search_term;
-    }
-    // Extract mentions for selection expansion.
-    if (!field_trial_->IsDecodeMentionsDisabled()) {
-      base::ListValue* mentions_list = NULL;
-      dict->GetList(kContextualSearchMentions, &mentions_list);
-      if (mentions_list != NULL && mentions_list->GetSize() >= 2)
-        ExtractMentionsStartEnd(*mentions_list, mention_start, mention_end);
-    }
-    // If either the selected text or the resolved term is not the search term,
-    // use it as the alternate term.
-    std::string selected_text;
-    dict->GetString(kContextualSearchResponseSelectedTextParam, &selected_text);
-    if (selected_text != *search_term) {
-      *alternate_term = selected_text;
-    } else {
-      std::string resolved_term;
-      dict->GetString(kContextualSearchResponseResolvedTermParam,
-                      &resolved_term);
-      if (resolved_term != *search_term) {
-        *alternate_term = resolved_term;
-      }
+  dict->GetString(kContextualSearchPreventPreload, prevent_preload);
+  dict->GetString(kContextualSearchResponseSearchTermParam, search_term);
+  dict->GetString(kContextualSearchResponseLanguageParam, lang);
+
+  // For the display_text, if not present fall back to the "search_term".
+  if (!dict->GetString(kContextualSearchResponseDisplayTextParam,
+                       display_text)) {
+    *display_text = *search_term;
+  }
+
+  // Extract mentions for selection expansion.
+  if (!field_trial_->IsDecodeMentionsDisabled()) {
+    base::ListValue* mentions_list = nullptr;
+    dict->GetList(kContextualSearchMentions, &mentions_list);
+    if (mentions_list && mentions_list->GetSize() >= 2)
+      ExtractMentionsStartEnd(*mentions_list, mention_start, mention_end);
+  }
+
+  // If either the selected text or the resolved term is not the search term,
+  // use it as the alternate term.
+  std::string selected_text;
+  dict->GetString(kContextualSearchResponseSelectedTextParam, &selected_text);
+  if (selected_text != *search_term) {
+    *alternate_term = selected_text;
+  } else {
+    std::string resolved_term;
+    dict->GetString(kContextualSearchResponseResolvedTermParam, &resolved_term);
+    if (resolved_term != *search_term) {
+      *alternate_term = resolved_term;
     }
   }
 }
 
 // Extract the Start/End of the mentions in the surrounding text
 // for selection-expansion.
 void ContextualSearchDelegate::ExtractMentionsStartEnd(
     const base::ListValue& mentions_list,
     int* startResult,
     int* endResult) {
@@ skipping 24 matching lines @@
     end_offset -= trim;
   }
   if (result_text.length() > end_offset + padding_each_side_pinned) {
     // Trim the end.
     result_text = result_text.substr(0, end_offset + padding_each_side_pinned);
   }
   *start = start_offset;
   *end = end_offset;
   return result_text;
 }