Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2909)

Unified Diff: content/shell/browser/layout_test/blink_test_controller.cc

Issue 2127303002: Make the crashed web platform pointerevent tests pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pointer event tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/gpu_benchmarking_extension.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/blink_test_controller.cc
diff --git a/content/shell/browser/layout_test/blink_test_controller.cc b/content/shell/browser/layout_test/blink_test_controller.cc
index 205c53ac03be3b05e016e6ba1ca858c6d2d76320..097b002e14fc3a26d9b0ede5dd1f3766582e3dac 100644
--- a/content/shell/browser/layout_test/blink_test_controller.cc
+++ b/content/shell/browser/layout_test/blink_test_controller.cc
@@ -59,6 +59,8 @@ namespace {
const int kTestSVGWindowWidthDip = 480;
const int kTestSVGWindowHeightDip = 360;
+const int kTestPointerEventWindowWidthDip = 1000;
+const int kTestPointerEventWindowHeightDip = 1200;
} // namespace
@@ -284,6 +286,11 @@ bool BlinkTestController::PrepareForLayoutTest(
// The W3C SVG layout tests use a different size than the other layout tests.
if (test_url.spec().find("W3C-SVG-1.1") != std::string::npos)
initial_size_ = gfx::Size(kTestSVGWindowWidthDip, kTestSVGWindowHeightDip);
+ // The W3C pointer event layout tests use a different size than the other
Rick Byers 2016/07/12 13:54:08 Ugh. I know you're just repeating the pattern abo
lanwei 2016/07/12 14:26:54 I agree. Navid, what do you think?
lanwei 2016/07/13 22:27:34 scrollIntoView can only align either to the top or
+ // layout tests.
+ if (test_url.spec().find("pointerevents") != std::string::npos)
+ initial_size_ = gfx::Size(kTestPointerEventWindowWidthDip,
+ kTestPointerEventWindowHeightDip);
if (!main_window_) {
main_window_ = content::Shell::CreateNewWindow(
browser_context,
« no previous file with comments | « content/renderer/gpu/gpu_benchmarking_extension.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698