Make the crashed web platform pointerevent tests pass

content/shell/browser/layout_test/blink_test_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/layout_test/blink_test_controller.h"
 
 #include <stddef.h>
 
 #include <iostream>
 #include <set>
@@ skipping 41 matching lines @@
 #include "content/shell/common/shell_messages.h"
 #include "content/shell/renderer/layout_test/blink_test_helpers.h"
 #include "ui/gfx/codec/png_codec.h"
 
 namespace content {
 
 namespace {
 
 const int kTestSVGWindowWidthDip = 480;
 const int kTestSVGWindowHeightDip = 360;
+const int kTestPointerEventWindowWidthDip = 1000;
+const int kTestPointerEventWindowHeightDip = 1200;
 
 }  // namespace
 
 // BlinkTestResultPrinter ----------------------------------------------------
 
 BlinkTestResultPrinter::BlinkTestResultPrinter(std::ostream* output,
                                                std::ostream* error)
     : state_(DURING_TEST),
       capture_text_only_(false),
       encode_binary_data_(false),
@@ skipping 205 matching lines @@
   main_window_render_process_hosts_.clear();
   accumulated_layout_test_runtime_flags_changes_.Clear();
   ShellBrowserContext* browser_context =
       ShellContentBrowserClient::Get()->browser_context();
   if (test_url.spec().find("compositing/") != std::string::npos)
     is_compositing_test_ = true;
   initial_size_ = Shell::GetShellDefaultSize();
   // The W3C SVG layout tests use a different size than the other layout tests.
   if (test_url.spec().find("W3C-SVG-1.1") != std::string::npos)
     initial_size_ = gfx::Size(kTestSVGWindowWidthDip, kTestSVGWindowHeightDip);
+  // The W3C pointer event layout tests use a different size than the other

[Rick Byers, 2016/07/12 13:54:08]

Ugh.  I know you're just repeating the pattern above, but this is pretty
magical. Can you not just have the test scroll down (eg. using
Element.scrollIntoView) as we had discussed?  Some tests may still exceed such a
height, really tests should be written not to assume any particular window size
(which is probably why we use a pretty small window size by default - better to
provoke tests more often).

[lanwei, 2016/07/12 14:26:54]

I agree. Navid, what do you think?

[lanwei, 2016/07/13 22:27:34]

scrollIntoView can only align either to the top or bottom of the view bound, but
we need to align with the left as well, so I use ScrollTo.

+  // layout tests.
+  if (test_url.spec().find("pointerevents") != std::string::npos)
+    initial_size_ = gfx::Size(kTestPointerEventWindowWidthDip,
+                              kTestPointerEventWindowHeightDip);
   if (!main_window_) {
     main_window_ = content::Shell::CreateNewWindow(
         browser_context,
         GURL(),
         NULL,
         initial_size_);
     WebContentsObserver::Observe(main_window_->web_contents());
     current_pid_ = base::kNullProcessId;
     main_window_->LoadURL(test_url);
   } else {
@@ skipping 631 matching lines @@
   } else {
     printer_->AddErrorMessage(base::StringPrintf(
         "FAIL: Unexpected sendBluetoothManualChooserEvent() event name '%s'.",
         event_name.c_str()));
     return;
   }
   bluetooth_chooser_factory_->SendEvent(event, argument);
 }
 
 }  // namespace content