Issue 21272003: Fix crash bug in the polymorphic inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21272003: Fix crash bug in the polymorphic inlining. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash bug in the polymorphic inlining. When inlining a polymorphic call site, we need to update the use lists so that the graph entry blocks of all the callee-graphs are removed from the environment use lists. TEST=tests/language/allocation_sinking_inlining_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25665

Patch Set 1 #

Patch Set 2 : fixed one more corner case #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	A	tests/language/allocation_sinking_inlining_test.dart	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 4 months ago (2013-07-31 14:57:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25665 (presubmit successful).

Expand Messages | Collapse Messages