Don't treat an empty value attribute as null on image input types

Don't treat an empty value attribute as null on image input types

If value="" is specified on an image-type form control then use "" as the alt-text
for the control if one is required. This matches Firefox and Edge, also IE11.

BUG=625604
Committed: https://crrev.com/350b1fecbdea7310b122e3e83c67929fa282d754
Cr-Commit-Position: refs/heads/master@{#404571}

[rhogan, 2016-07-08 17:57:55]

Description was changed from

==========
Don't treat an empty value attribute as null on image input types

BUG=625604
==========

to

==========
Don't treat an empty value attribute as null on image input types

If value="" is specified on an image-type form control then use "" as the
alt-text
for the control if one is required. This matches Firefox and Edge, also IE11.

BUG=625604
==========

[rhogan, 2016-07-08 18:00:00]

robhogan@gmail.com changed reviewers:
+ pdr@google.com

[pdr., 2016-07-08 18:46:05]

On 2016/07/08 at 18:00:01, robhogan wrote:
> 

Nice!


LGTM

[rhogan, 2016-07-09 10:18:29]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-07-09 10:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 12:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 12:19:42]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[rhogan, 2016-07-09 14:10:26]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-07-09 14:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 16:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 16:11:10]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[rhogan, 2016-07-09 22:10:53]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-07-09 22:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 22:14:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-09 22:14:56]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-09 22:16:16]

Description was changed from

==========
Don't treat an empty value attribute as null on image input types

If value="" is specified on an image-type form control then use "" as the
alt-text
for the control if one is required. This matches Firefox and Edge, also IE11.

BUG=625604
==========

to

==========
Don't treat an empty value attribute as null on image input types

If value="" is specified on an image-type form control then use "" as the
alt-text
for the control if one is required. This matches Firefox and Edge, also IE11.

BUG=625604

Committed: https://crrev.com/350b1fecbdea7310b122e3e83c67929fa282d754
Cr-Commit-Position: refs/heads/master@{#404571}
==========

[commit-bot: I haz the power, 2016-07-09 22:16:17]

Patchset 1 (id:??) landed as
https://crrev.com/350b1fecbdea7310b122e3e83c67929fa282d754
Cr-Commit-Position: refs/heads/master@{#404571}