third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 2127093004: Don't treat an empty value attribute as null on image input types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2127093004: Don't treat an empty value attribute as null on image input types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@467579

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index abb28d39af6b814cf3d5e44226af3712041dfb39..aef2434708d13cc21dd7f91f981022849856f837 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -827,7 +827,7 @@ String HTMLInputElement::altText() const

alt = fastGetAttribute(titleAttr);

if (alt.isNull())

alt = fastGetAttribute(valueAttr);

- if (alt.isEmpty())

+ if (alt.isNull())

alt = locale().queryString(WebLocalizedString::InputElementAltText);

return alt;

}

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/input-image-button-with-empty-value-expected.html ('k') | no next file » | no next file with comments »