Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2127043002: SegmentedString::prepend should know if the prepended string is new or previously consumed (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SegmentedString::prepend should know if the prepended string is new or previously consumed This CL fixes the FIXME in SegmentedString::prepend partially. This CL also fixes the test failures in upcoming CL: https://codereview.chromium.org/2121703002/ Before this CL, we messed up the m_numberOfCharactersConsumedPriorToCurrentString counter when BackgroundHTMLInputStream is rewound for document.write inputs. BUG=619141 Committed: https://crrev.com/0a5bb3d7a08957ac247f5d7c458b7a225d54d56c Cr-Commit-Position: refs/heads/master@{#404116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.h View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.cpp View 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kouhei (in TOK)
tkent-san: Would you take a look?
4 years, 5 months ago (2016-07-07 05:56:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127043002/1
4 years, 5 months ago (2016-07-07 05:57:10 UTC) #4
tkent
lgtm
4 years, 5 months ago (2016-07-07 06:04:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 07:16:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127043002/1
4 years, 5 months ago (2016-07-07 09:43:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:47:43 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:49:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a5bb3d7a08957ac247f5d7c458b7a225d54d56c
Cr-Commit-Position: refs/heads/master@{#404116}

Powered by Google App Engine
This is Rietveld 408576698