third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp - Issue 2127043002: SegmentedString::prepend should know if the prepended string is new or previously consumed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp

Issue 2127043002: SegmentedString::prepend should know if the prepended string is new or previously consumed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp ('k') | third_party/WebKit/Source/platform/text/SegmentedString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp

index 43fc4ebf69ca3edd058567d9d60840ef62c76d54..cd8005abd05226d192a35e12f90e4ba89744afce 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp

@@ -97,7 +97,8 @@ static void unconsumeCharacters(SegmentedString& source, ConsumedCharacterBuffer

source.push(consumedCharacters[1]);

source.push(consumedCharacters[0]);

} else

- source.prepend(SegmentedString(String(consumedCharacters)));

+ source.prepend(SegmentedString(String(consumedCharacters)),

+ SegmentedString::PrependType::Unconsume);

}

static bool consumeNamedEntity(SegmentedString& source, DecodedHTMLEntity& decodedEntity, bool& notEnoughCharacters, UChar additionalAllowedCharacter, UChar& cc)