content/renderer/render_view_impl.h - Issue 212703005: Preserve Page::openedByDOM state across process swaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 212703005: Preserve Page::openedByDOM state across process swaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nasko comments. (Also a rebase. Oops.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index e08d17d492a8afe413021b8129f1be349f795237..28805dd9a3b0409b051121662abb1796caa44d2a 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -181,8 +181,11 @@ class CONTENT_EXPORT RenderViewImpl

public base::SupportsWeakPtr<RenderViewImpl> {

public:

// Creates a new RenderView. |opener_id| is the routing ID of the RenderView

- // responsible for creating this RenderView.

+ // responsible for creating this RenderView. Note that if the original opener

+ // has been closed, |window_was_created_with_opener| will be true and

+ // |opened_id| will be MSG_ROUTING_NONE.

nasko 2014/04/08 23:57:20 nit: opener_id

davidben 2014/04/09 16:43:19 Done.

static RenderViewImpl* Create(int32 opener_id,

+ bool window_was_created_with_opener,

const RendererPreferences& renderer_prefs,

const WebPreferences& webkit_prefs,

int32 routing_id,

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »