Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2271)

Unified Diff: content/renderer/render_view_impl.cc

Issue 212703005: Preserve Page::openedByDOM state across process swaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nasko comments. (Also a rebase. Oops.) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index f99c6ff3c26fd74261c3fc753d61741b043061b1..3366380e7a8fac93f852fe1bdead745865f84909 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -791,6 +791,10 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {
if (!params->frame_name.empty())
webview()->mainFrame()->setName(params->frame_name);
+ // TODO(davidben): Move this state from Blink into content.
+ if (params->window_was_created_with_opener)
+ webview()->setOpenedByDOM();
+
OnSetRendererPrefs(params->renderer_prefs);
#if defined(ENABLE_WEBRTC)
@@ -914,6 +918,7 @@ void RenderView::ForEach(RenderViewVisitor* visitor) {
/*static*/
RenderViewImpl* RenderViewImpl::Create(
int32 opener_id,
+ bool window_was_created_with_opener,
const RendererPreferences& renderer_prefs,
const WebPreferences& webkit_prefs,
int32 routing_id,
@@ -929,6 +934,7 @@ RenderViewImpl* RenderViewImpl::Create(
AccessibilityMode accessibility_mode) {
DCHECK(routing_id != MSG_ROUTING_NONE);
RenderViewImplParams params(opener_id,
+ window_was_created_with_opener,
renderer_prefs,
webkit_prefs,
routing_id,
@@ -1538,6 +1544,7 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,
// disagrees.
RenderViewImpl* view = RenderViewImpl::Create(
routing_id_,
+ true, // window_was_created_with_opener
renderer_preferences_,
transferred_preferences,
routing_id,

Powered by Google App Engine
This is Rietveld 408576698