[Oilpan]: Move StyleKeyFrame to the oilpan heap using transition types.

[Oilpan]: Move StyleKeyFrame to the oilpan heap using transition types.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170064

[haraken, 2014-03-26 13:17:12]

LGTM

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSGrammar.y
File Source/core/css/CSSGrammar.y (right):

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSGrammar.y...
Source/core/css/CSSGrammar.y:91:
WillBeHeapVector<RefPtrWillBeMember<StyleKeyframe> >* keyframeRuleList;

Can you move this up to line 80 so that the comment in line 76 applies to this
WillBeHeapVector?

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
File Source/core/css/CSSKeyframeRule.h (right):

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
Source/core/css/CSSKeyframeRule.h:71: RefPtr<StylePropertySet> m_properties;

You can make this a Member. StylePropertySet is already on the heap.

[wibling-chromium, 2014-03-26 13:31:33]

Thanks for the review!

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
File Source/core/css/CSSKeyframeRule.h (right):

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
Source/core/css/CSSKeyframeRule.h:71: RefPtr<StylePropertySet> m_properties;
On 2014/03/26 13:17:12, haraken wrote:
> 
> You can make this a Member. StylePropertySet is already on the heap.

I would rather wait until I have the Mutable and ImmutablePropertySets moved to
the transition types. Otherwise I will have to do part of that change here to
make sure I can set the member using a RawPtr.

[wibling-chromium, 2014-03-26 13:31:55]

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSGrammar.y
File Source/core/css/CSSGrammar.y (right):

https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSGrammar.y...
Source/core/css/CSSGrammar.y:91:
WillBeHeapVector<RefPtrWillBeMember<StyleKeyframe> >* keyframeRuleList;
On 2014/03/26 13:17:12, haraken wrote:
> 
> Can you move this up to line 80 so that the comment in line 76 applies to this
> WillBeHeapVector?

Done.

[haraken, 2014-03-26 13:38:52]

>
https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
> File Source/core/css/CSSKeyframeRule.h (right):
> 
>
https://codereview.chromium.org/212703003/diff/1/Source/core/css/CSSKeyframeR...
> Source/core/css/CSSKeyframeRule.h:71: RefPtr<StylePropertySet> m_properties;
> On 2014/03/26 13:17:12, haraken wrote:
> > 
> > You can make this a Member. StylePropertySet is already on the heap.
> 
> I would rather wait until I have the Mutable and ImmutablePropertySets moved
to
> the transition types. Otherwise I will have to do part of that change here to
> make sure I can set the member using a RawPtr.

Makes sense. LGTM.

[wibling-chromium, 2014-03-26 13:39:57]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-03-26 13:39:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/212703003/100001

[commit-bot: I haz the power, 2014-03-26 13:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 13:46:57]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[wibling-chromium, 2014-03-26 13:53:06]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-03-26 13:53:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/212703003/100001

[zerny-chromium, 2014-03-26 14:10:52]

lgtm

[commit-bot: I haz the power, 2014-03-26 14:48:09]

Change committed as 170064