[Oilpan]: Move StyleKeyFrame to the oilpan heap using transition types.

Source/core/css/CSSKeyframeRule.h

 /*
  * Copyright (C) 2007, 2008, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 
 namespace WebCore {
 
 class CSSKeyframesRule;
 class CSSParserValueList;
 class CSSStyleDeclaration;
 class MutableStylePropertySet;
 class StylePropertySet;
 class StyleRuleCSSStyleDeclaration;
 
-class StyleKeyframe FINAL : public RefCounted<StyleKeyframe> {
-    WTF_MAKE_FAST_ALLOCATED;
+class StyleKeyframe FINAL : public RefCountedWillBeGarbageCollectedFinalized<StyleKeyframe> {
+    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 public:
-    static PassRefPtr<StyleKeyframe> create()
+    static PassRefPtrWillBeRawPtr<StyleKeyframe> create()
     {
-        return adoptRef(new StyleKeyframe());
+        return adoptRefWillBeNoop(new StyleKeyframe());
     }
     ~StyleKeyframe();
 
     // Exposed to JavaScript.
     String keyText() const;
     void setKeyText(const String&);
 
     // Used by StyleResolver.
     const Vector<double>& keys() const;
     // Used by BisonCSSParser when constructing a new StyleKeyframe.
     void setKeys(PassOwnPtr<Vector<double> >);
 
     const StylePropertySet& properties() const { return *m_properties; }
     MutableStylePropertySet& mutableProperties();
     void setProperties(PassRefPtr<StylePropertySet>);
 
     String cssText() const;
 
+    void trace(Visitor*) { }
+
     static PassOwnPtr<Vector<double> > createKeyList(CSSParserValueList*);
 
 private:
     StyleKeyframe();
 
     RefPtr<StylePropertySet> m_properties;

[haraken, 2014/03/26 13:17:12]

You can make this a Member. StylePropertySet is already on the heap.

[wibling-chromium, 2014/03/26 13:31:33]

I would rather wait until I have the Mutable and ImmutablePropertySets moved to
the transition types. Otherwise I will have to do part of that change here to
make sure I can set the member using a RawPtr.

     // These are both calculated lazily. Either one can be set, which invalidates the other.
     mutable String m_keyText;
     mutable OwnPtr<Vector<double> > m_keys;
 };
 
 class CSSKeyframeRule FINAL : public CSSRule {
 public:
     virtual ~CSSKeyframeRule();
 
     virtual CSSRule::Type type() const OVERRIDE { return KEYFRAME_RULE; }
     virtual String cssText() const OVERRIDE { return m_keyframe->cssText(); }
     virtual void reattach(StyleRuleBase*) OVERRIDE;
 
     String keyText() const { return m_keyframe->keyText(); }
     void setKeyText(const String& s) { m_keyframe->setKeyText(s); }
 
     CSSStyleDeclaration* style() const;
 
-    virtual void trace(Visitor* visitor) OVERRIDE { CSSRule::trace(visitor); }
+    virtual void trace(Visitor*) OVERRIDE;
 
 private:
     CSSKeyframeRule(StyleKeyframe*, CSSKeyframesRule* parent);
 
-    RefPtr<StyleKeyframe> m_keyframe;
+    RefPtrWillBeMember<StyleKeyframe> m_keyframe;
     mutable RefPtr<StyleRuleCSSStyleDeclaration> m_propertiesCSSOMWrapper;
 
     friend class CSSKeyframesRule;
 };
 
 DEFINE_CSS_RULE_TYPE_CASTS(CSSKeyframeRule, KEYFRAME_RULE);
 
 } // namespace WebCore
 
 #endif // CSSKeyframeRule_h