Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 2126923002: [Sync] Stop purging sync data on restart for users who haven't finished setup. (Closed)

Created:
4 years, 5 months ago by Nicolas Zea
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Sync] Stop purging sync data on restart for users who haven't finished setup. Users who don't have first setup complete, but are signed in without sync suppressed, are in an invalid state, likely from previous issues in the sign in flow. We were purging their sync data over-aggressively on startup previously, causing a resync of the control types on each restart. Now we simply leave the data around, and only purge if the user is actually signed out. BUG=624915 Review-Url: https://codereview.chromium.org/2113453006 Cr-Commit-Position: refs/heads/master@{#403382} (cherry picked from commit 68623971be0cfc492a2cb0427d7f478e7b214c24) Committed: https://chromium.googlesource.com/chromium/src/+/97128793647d0829e901967a6524563f6796fed2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Nicolas Zea
4 years, 5 months ago (2016-07-06 20:48:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97128793647d0829e901967a6524563f6796fed2.

Powered by Google App Engine
This is Rietveld 408576698