Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2113453006: [Sync] Stop purging sync data on restart for users who haven't finished setup. (Closed)

Created:
4 years, 5 months ago by Nicolas Zea
Modified:
4 years, 5 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Stop purging sync data on restart for users who haven't finished setup. Users who don't have first setup complete, but are signed in without sync suppressed, are in an invalid state, likely from previous issues in the sign in flow. We were purging their sync data over-aggressively on startup previously, causing a resync of the control types on each restart. Now we simply leave the data around, and only purge if the user is actually signed out. BUG=624915 Committed: https://crrev.com/68623971be0cfc492a2cb0427d7f478e7b214c24 Cr-Commit-Position: refs/heads/master@{#403382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nicolas Zea
PTAL!
4 years, 5 months ago (2016-07-01 00:15:39 UTC) #2
pavely
lgtm
4 years, 5 months ago (2016-07-01 00:24:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113453006/1
4 years, 5 months ago (2016-07-01 01:27:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 01:34:19 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 01:34:27 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:36:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68623971be0cfc492a2cb0427d7f478e7b214c24
Cr-Commit-Position: refs/heads/master@{#403382}

Powered by Google App Engine
This is Rietveld 408576698