Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Issue 2126913002: Fix bounds computation for non-aa hairlines when snapping to pixel centers (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bounds computation for non-aa hairlines when snapping to pixel centers BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126913002 Committed: https://skia.googlesource.com/skia/+/7e8cc21d574e00d13391da59f00be6bba62c31cd

Patch Set 1 #

Patch Set 2 : fix int scalar warning #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (8 generated)
egdaniel
4 years, 5 months ago (2016-07-06 20:29:49 UTC) #3
robertphillips
lgtm
4 years, 5 months ago (2016-07-06 20:31:57 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126913002/1
4 years, 5 months ago (2016-07-06 20:32:10 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/9598)
4 years, 5 months ago (2016-07-06 20:40:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126913002/20001
4 years, 5 months ago (2016-07-06 20:52:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7e8cc21d574e00d13391da59f00be6bba62c31cd
4 years, 5 months ago (2016-07-06 21:38:37 UTC) #13
bsalomon
4 years, 5 months ago (2016-07-07 14:19:06 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2126913002/diff/20001/src/gpu/batches/GrNonAA...
File src/gpu/batches/GrNonAAStrokeRectBatch.cpp (right):

https://codereview.chromium.org/2126913002/diff/20001/src/gpu/batches/GrNonAA...
src/gpu/batches/GrNonAAStrokeRectBatch.cpp:113: bounds->roundOut();
Do we need this round out? If the rect is rendered at pixel centers the bounds
be at half integers?

Powered by Google App Engine
This is Rietveld 408576698