Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2126803002: Fix typo in multi-iframe NTP JS (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in multi-iframe NTP JS Follow-up to https://codereview.chromium.org/2117373002/ which broke this. BUG=625161 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/685953392608663cae88b39dbaf65c45fb685d40 Cr-Commit-Position: refs/heads/master@{#404101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/local_ntp/most_visited_util.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126803002/1
4 years, 5 months ago (2016-07-06 12:20:08 UTC) #3
Marc Treib
A testament to our exhaustive test coverage, and also to the awesomeness that is JS.
4 years, 5 months ago (2016-07-06 12:20:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 13:12:21 UTC) #7
Bernhard Bauer
Yeesh... LGTM.
4 years, 5 months ago (2016-07-06 17:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126803002/1
4 years, 5 months ago (2016-07-07 08:31:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:13:52 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:14:02 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/685953392608663cae88b39dbaf65c45fb685d40 Cr-Commit-Position: refs/heads/master@{#404101}
4 years, 5 months ago (2016-07-07 09:15:07 UTC) #14
phoglund_chromium
Marc, is this fix related to the Mac ASAN compile error in the build before? ...
4 years, 5 months ago (2016-07-07 12:11:38 UTC) #16
Marc Treib
4 years, 5 months ago (2016-07-07 12:13:07 UTC) #17
Message was sent while issue was closed.
On 2016/07/07 12:11:38, phoglund_chrome wrote:
> Marc, is this fix related to the Mac ASAN compile error in the build before?
>
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Build...
> 
> If this patch fixed that compile error, carry on. Otherwise let me know and
I'll
> file a bug on infra (in that case compilation must be flaky).

No, that looks unrelated.

Powered by Google App Engine
This is Rietveld 408576698