Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2124953004: Remove a bunch of broken/unused/non-useful NTP UMA histograms (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a bunch of broken/unused/non-useful NTP UMA histograms BUG=625154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9c7f7e1c7c7f87b2b9965cc38561ababf3812ed3 Cr-Commit-Position: refs/heads/master@{#404649}

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -170 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_single.js View 1 2 3 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.js View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_util.js View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.h View 1 2 3 4 chunks +4 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc View 1 2 3 7 chunks +14 lines, -71 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/common/search/ntp_logging_events.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 7 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Marc Treib
This will need some rebasing, but ready for a first look.
4 years, 5 months ago (2016-07-06 12:32:18 UTC) #3
sfiera
lgtm
4 years, 5 months ago (2016-07-06 12:37:11 UTC) #4
Marc Treib
holte: Please look at histograms.xml bauerb: Please look at everything else :) (already reviewed by ...
4 years, 5 months ago (2016-07-06 14:15:53 UTC) #6
Steven Holte
histograms lgtm
4 years, 5 months ago (2016-07-06 17:51:50 UTC) #7
Bernhard Bauer
(Rubber) stamp of approval! 😃 LGTM.
4 years, 5 months ago (2016-07-07 08:43:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124953004/60001
4 years, 5 months ago (2016-07-11 13:37:16 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-11 13:42:05 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 13:42:12 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 13:45:42 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9c7f7e1c7c7f87b2b9965cc38561ababf3812ed3
Cr-Commit-Position: refs/heads/master@{#404649}

Powered by Google App Engine
This is Rietveld 408576698