Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2126743002: Make previousPositionOf() to handle yet another no previous position case (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make previousPositionOf() to handle yet another no previous position case This patch makes |previousPositionOf()| to handle no previous position case, which is occurred after visible position canonicalization. It is time to change |DCEHCK()| to return nothing since we have a test case for it. BUG=619131 TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitTests.previousPositionOfNoPreviousPosition Committed: https://crrev.com/b0ff83a86d043140c423a47c164d43fab5a552bb Cr-Commit-Position: refs/heads/master@{#403887}

Patch Set 1 : 2016-07-06T16:42:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-06 08:16:38 UTC) #4
yoichio
lgtm
4 years, 5 months ago (2016-07-06 09:07:50 UTC) #5
Xiaocheng
lgtm
4 years, 5 months ago (2016-07-06 09:14:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126743002/1
4 years, 5 months ago (2016-07-06 11:32:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 12:08:25 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 12:08:30 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 12:09:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0ff83a86d043140c423a47c164d43fab5a552bb
Cr-Commit-Position: refs/heads/master@{#403887}

Powered by Google App Engine
This is Rietveld 408576698