third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 2126743002: Make previousPositionOf() to handle yet another no previous position case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2126743002: Make previousPositionOf() to handle yet another no previous position case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-07-06T16:42:17 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index 7b30823c64f843c49fe293a8b9f2e95f80c05adc..797c2e7516347a9a0e929e5c4afda5182c7816d0 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -3232,7 +3232,8 @@ static VisiblePositionTemplate<Strategy> previousPositionOfAlgorithm(const Visib

// never yield another |TextAffinity::Upstream position| (unless line wrap

// length is 0!).

const VisiblePositionTemplate<Strategy> prev = createVisiblePosition(pos);

- DCHECK_NE(prev.deepEquivalent(), visiblePosition.deepEquivalent());

+ if (prev.deepEquivalent() == visiblePosition.deepEquivalent())

+ return VisiblePositionTemplate<Strategy>();

switch (rule) {

case CanCrossEditingBoundary:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp » ('j') | no next file with comments »