Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 212673008: Revert of Add a check to the FindBadConstructs.cpp clang plugin for bad enum last values. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Add a check to the FindBadConstructs.cpp clang plugin for bad enum last values. (https://codereview.chromium.org/150943005/) Reason for revert: Caused crbug.com/356815 and crbug.com/356816 and doesn't have a flag to turn it off. Original issue's description: > Add a check to the FindBadConstructs.cpp clang plugin for bad enum last values. > > One common coding patern is to define an enum as in: > enum Color { RED, GREEN, BLUE, COLOR_LAST=BLUE }; > but this is fragile when someone adds a new constant and forgets > to update the COLOR_LAST constant. > > This change looks for enums that have a xxx_LAST or xxxLast member, > and warns if there are any higher-valued constants present. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251894 TBR=erg@google.com,darin@chromium.org,erg@chromium.org,tsepez@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M tools/clang/plugins/ChromeClassTester.h View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M tools/clang/plugins/FindBadConstructs.cpp View 5 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of Add a check to the FindBadConstructs.cpp clang plugin for bad enum last ...
6 years, 9 months ago (2014-03-26 20:44:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/212673008/1
6 years, 9 months ago (2014-03-26 20:45:15 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 20:46:52 UTC) #3
Message was sent while issue was closed.
Change committed as 259675

Powered by Google App Engine
This is Rietveld 408576698