Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 212673008: Revert of Add a check to the FindBadConstructs.cpp clang plugin for bad enum last values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index 94e89f7a02d1812e05190fecc0359d3f3d05ad4e..7336cc859e22b40ee4ffac188c4b519d5fc2e548 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -93,16 +93,6 @@
return;
CheckChromeClass(record_location, record);
- } else if (EnumDecl* enum_decl = dyn_cast<EnumDecl>(tag)) {
- SourceLocation enum_location = enum_decl->getInnerLocStart();
- if (InBannedDirectory(enum_location))
- return;
-
- std::string base_name = enum_decl->getNameAsString();
- if (IsIgnoredType(base_name))
- return;
-
- CheckChromeEnum(enum_location, enum_decl);
}
}
@@ -210,9 +200,6 @@
// non-pod class member. Probably harmless.
ignored_record_names_.insert("MockTransaction");
- // Enum type with _LAST members where _LAST doesn't mean last enum value.
- ignored_record_names_.insert("ServerFieldType");
-
// Used heavily in ui_unittests and once in views_unittests. Fixing this
// isn't worth the overhead of an additional library.
ignored_record_names_.insert("TestAnimationDelegate");
@@ -224,9 +211,6 @@
// Measured performance improvement on cc_perftests. See
// https://codereview.chromium.org/11299290/
ignored_record_names_.insert("QuadF");
-
- // Enum type with _LAST members where _LAST doesn't mean last enum value.
- ignored_record_names_.insert("ViewID");
}
std::string ChromeClassTester::GetNamespaceImpl(const DeclContext* context,
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698